lib/tdb/common: Fix Array access results in a null pointer dereference

Fixes;

lib/tdb/common/transaction.c:613:7: warning: Array access (via field 'blocks') results in a null pointer dereference <--[clang]
                if (tdb->transaction->blocks[i] != NULL) {
                    ^
1 warning generated.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

diff --git a/lib/tdb/common/transaction.c b/lib/tdb/common/transaction.c
index 290451b328555d25fd1398637e66c2da5eca50eb..06710896b6bac662c0b474c395fcc81288eb7ade 100644 (file)
--- a/lib/tdb/common/transaction.c
+++ b/lib/tdb/common/transaction.c
@@ -610,7 +610,8 @@ static int _tdb_transaction_cancel(struct tdb_context *tdb)
 
        /* free all the transaction blocks */
        for (i=0;i<tdb->transaction->num_blocks;i++) {
-               if (tdb->transaction->blocks[i] != NULL) {
+               if (tdb->transaction->blocks &&
+                   tdb->transaction->blocks[i] != NULL) {
                        free(tdb->transaction->blocks[i]);
                }
        }