]> git.ipfire.org Git - thirdparty/dbus.git/commitdiff
test: Fix reading off the end of an array in test-corrupt
authorPhilip Withnall <withnall@endlessm.com>
Wed, 5 Apr 2017 10:35:27 +0000 (11:35 +0100)
committerSimon McVittie <smcv@debian.org>
Wed, 5 Apr 2017 15:22:22 +0000 (16:22 +0100)
One level of pointer indirection too many when passing the arguments to
dbus_message_append_args().

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=100568
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Reviewed-by: Simon McVittie <smcv@collabora.com>
test/corrupt.c

index d106fcc5b2ddd1f90f7323e45a4409d5c493a661..56a0cdf2a75847628c2194e88d2eaed4d7c6a6b9 100644 (file)
@@ -271,7 +271,6 @@ test_byte_order (Fixture *f,
   int fd;
   char *blob;
   const gchar *arg = not_a_dbus_message;
-  const gchar * const *args = &arg;
   int blob_len;
   DBusMessage *message;
   dbus_bool_t mem;
@@ -283,7 +282,7 @@ test_byte_order (Fixture *f,
   /* Append 0xFF bytes, so that the length of the body when byte-swapped
    * is 0xFF000000, which is invalid */
   mem = dbus_message_append_args (message,
-      DBUS_TYPE_ARRAY, DBUS_TYPE_BYTE, &args, 0xFF,
+      DBUS_TYPE_ARRAY, DBUS_TYPE_BYTE, &arg, 0xFF,
       DBUS_TYPE_INVALID);
   g_assert (mem);
   mem = dbus_message_marshal (message, &blob, &blob_len);