]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ipmi: ipmb: initialise event handler read bytes
authorMatt Johnston <matt@codeconstruct.com.au>
Tue, 13 Jan 2026 09:41:34 +0000 (17:41 +0800)
committerCorey Minyard <corey@minyard.net>
Wed, 4 Feb 2026 03:06:18 +0000 (21:06 -0600)
IPMB doesn't use i2c reads, but the handler needs to set a value.
Otherwise an i2c read will return an uninitialised value from the bus
driver.

Fixes: 63c4eb347164 ("ipmi:ipmb: Add initial support for IPMI over IPMB")
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Message-ID: <20260113-ipmb-read-init-v1-1-a9cbce7b94e3@codeconstruct.com.au>
Signed-off-by: Corey Minyard <corey@minyard.net>
drivers/char/ipmi/ipmi_ipmb.c

index 3a51e58b24875497699c7af7a4af1c73b47653f3..28818952a7a4bf814b95bdfb7046672ad4526cf2 100644 (file)
@@ -202,11 +202,16 @@ static int ipmi_ipmb_slave_cb(struct i2c_client *client,
                break;
 
        case I2C_SLAVE_READ_REQUESTED:
+               *val = 0xff;
+               ipmi_ipmb_check_msg_done(iidev);
+               break;
+
        case I2C_SLAVE_STOP:
                ipmi_ipmb_check_msg_done(iidev);
                break;
 
        case I2C_SLAVE_READ_PROCESSED:
+               *val = 0xff;
                break;
        }