]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.12] gh-117110: Fix subclasses of typing.Any with custom constructors (GH-117111...
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Fri, 29 Mar 2024 00:36:14 +0000 (01:36 +0100)
committerGitHub <noreply@github.com>
Fri, 29 Mar 2024 00:36:14 +0000 (00:36 +0000)
gh-117110: Fix subclasses of typing.Any with custom constructors (GH-117111)
(cherry picked from commit 8eec7ed714e65d616573b7331780b0aa43c6ed6a)

Co-authored-by: 傅立业(Chris Fu) <17433201@qq.com>
Lib/test/test_typing.py
Lib/typing.py
Misc/NEWS.d/next/Library/2024-03-21-07-27-36.gh-issue-117110.9K1InX.rst [new file with mode: 0644]

index 8ad26a77e5dbca3070e05aeb6f6b687595c8a71a..dc117b348210bb75214f8fca1c2b84cdb21ec88a 100644 (file)
@@ -141,6 +141,26 @@ class AnyTests(BaseTestCase):
         self.assertIsInstance(ms, Something)
         self.assertIsInstance(ms, Mock)
 
+    def test_subclassing_with_custom_constructor(self):
+        class Sub(Any):
+            def __init__(self, *args, **kwargs): pass
+        # The instantiation must not fail.
+        Sub(0, s="")
+
+    def test_multiple_inheritance_with_custom_constructors(self):
+        class Foo:
+            def __init__(self, x):
+                self.x = x
+
+        class Bar(Any, Foo):
+            def __init__(self, x, y):
+                self.y = y
+                super().__init__(x)
+
+        b = Bar(1, 2)
+        self.assertEqual(b.x, 1)
+        self.assertEqual(b.y, 2)
+
     def test_cannot_instantiate(self):
         with self.assertRaises(TypeError):
             Any()
index 1d8feed5ebcb82823adbfce9d8fefd44b3632293..c9962b9c9bccadbffa923208868c82c873cf815b 100644 (file)
@@ -544,7 +544,7 @@ class Any(metaclass=_AnyMeta):
     def __new__(cls, *args, **kwargs):
         if cls is Any:
             raise TypeError("Any cannot be instantiated")
-        return super().__new__(cls, *args, **kwargs)
+        return super().__new__(cls)
 
 
 @_SpecialForm
diff --git a/Misc/NEWS.d/next/Library/2024-03-21-07-27-36.gh-issue-117110.9K1InX.rst b/Misc/NEWS.d/next/Library/2024-03-21-07-27-36.gh-issue-117110.9K1InX.rst
new file mode 100644 (file)
index 0000000..32f8f81
--- /dev/null
@@ -0,0 +1 @@
+Fix a bug that prevents subclasses of :class:`typing.Any` to be instantiated with arguments. Patch by Chris Fu.