]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: camss: Replace hard coded value with parameter
authorSouptick Joarder (HPE) <jrdr.linux@gmail.com>
Tue, 1 Mar 2022 06:05:30 +0000 (11:35 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 3 Dec 2023 06:31:23 +0000 (07:31 +0100)
[ Upstream commit a312f8982632fb1a882a8dc3c9fd127d082c1c02 ]

Kernel test robot reported below warning ->
drivers/media/platform/qcom/camss/camss-csid-gen2.c:407:3:
warning: Value stored to 'val' is never read
[clang-analyzer-deadcode.DeadStores]

Replace hard coded value with val.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Stable-dep-of: e655d1ae9703 ("media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater than 3")
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/platform/qcom/camss/camss-csid-170.c

index 82f59933ad7b35272cdcddd0efbce96ce9c17dec..c234b8d67bc592e232eb120235f323db4511ad74 100644 (file)
@@ -398,7 +398,7 @@ static void csid_configure_stream(struct csid_device *csid, u8 enable)
                writel_relaxed(val, csid->base + CSID_RDI_FRM_DROP_PERIOD(0));
 
                val = 0;
-               writel_relaxed(0, csid->base + CSID_RDI_FRM_DROP_PATTERN(0));
+               writel_relaxed(val, csid->base + CSID_RDI_FRM_DROP_PATTERN(0));
 
                val = 1;
                writel_relaxed(val, csid->base + CSID_RDI_IRQ_SUBSAMPLE_PERIOD(0));