]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.11] gh-116682: stdout may be empty in test_cancel_futures_wait_false (GH-116683...
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Wed, 13 Mar 2024 00:29:03 +0000 (01:29 +0100)
committerGitHub <noreply@github.com>
Wed, 13 Mar 2024 00:29:03 +0000 (00:29 +0000)
If the `shutdown()` call happens before the worker thread starts executing
the task, then nothing will be printed to stdout.
(cherry picked from commit 7d1abe9502641a3602e9773aebc29ee56d8f40ae)

Co-authored-by: Sam Gross <colesbury@gmail.com>
Lib/test/test_concurrent_futures/test_shutdown.py

index 45dab7a75fdd504c5d170dff61cf478a0934cb96..7a4065afd46fc840fa62d4450258e0a0c6ee05ce 100644 (file)
@@ -247,7 +247,9 @@ class ThreadPoolShutdownTest(ThreadPoolMixin, ExecutorShutdownTest, BaseTestCase
         # Errors in atexit hooks don't change the process exit code, check
         # stderr manually.
         self.assertFalse(err)
-        self.assertEqual(out.strip(), b"apple")
+        # gh-116682: stdout may be empty if shutdown happens before task
+        # starts executing.
+        self.assertIn(out.strip(), [b"apple", b""])
 
 
 class ProcessPoolShutdownTest(ExecutorShutdownTest):