]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
x86_64: Unconditionally run test elf/check-dt-x86-64-plt
authorArjun Shankar <arjun@redhat.com>
Thu, 4 Sep 2025 18:30:41 +0000 (20:30 +0200)
committerArjun Shankar <arjun@redhat.com>
Thu, 4 Sep 2025 21:05:56 +0000 (23:05 +0200)
The intention of GLIBC_ABI_DT_X86_64_PLT is simply to mark the existence
of the fix in f8587a61892cbafd98ce599131bf4f103466f084
("x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT").

Testing for GLIBC_ABI_DT_X86_64_PLT does not depend on the linker
supporting -z mark-plt.  Therefore remove this dependency on linker
support and test unconditionally.

Fixes commit 399384e0c8193e31aea014220ccfa24300ae5938
("x86-64: Add GLIBC_ABI_DT_X86_64_PLT [BZ #33212]")

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
sysdeps/x86_64/Makefile

index 9792e472dc106ab1c5a1b82887366f5c42030025..ff0463d7caa88973755cf0fa7a65ef9a697419c4 100644 (file)
@@ -213,6 +213,7 @@ LDFLAGS-tst-plt-rewrite2 = -Wl,-z,now
 LDFLAGS-tst-plt-rewritemod2.so = -Wl,-z,now,-z,undefs
 tst-plt-rewrite2-ENV = GLIBC_TUNABLES=glibc.cpu.plt_rewrite=2
 $(objpfx)tst-plt-rewrite2: $(objpfx)tst-plt-rewritemod2.so
+endif
 
 tests-special += $(objpfx)check-dt-x86-64-plt.out
 
@@ -222,7 +223,6 @@ $(objpfx)check-dt-x86-64-plt.out: $(common-objpfx)libc.so
                | grep GLIBC_ABI_DT_X86_64_PLT > $@; \
        $(evaluate-test)
 generated += check-dt-x86-64-plt.out
-endif
 
 test-internal-extras += tst-gnu2-tls2mod1