]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/msm: fix the highest_bank_bit for sc7180
authorAbhinav Kumar <quic_abhinavk@quicinc.com>
Thu, 8 Aug 2024 23:52:27 +0000 (16:52 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Aug 2024 15:36:03 +0000 (17:36 +0200)
[ Upstream commit 3e30296b374af33cb4c12ff93df0b1e5b2d0f80b ]

sc7180 programs the ubwc settings as 0x1e as that would mean a
highest bank bit of 14 which matches what the GPU sets as well.

However, the highest_bank_bit field of the msm_mdss_data which is
being used to program the SSPP's fetch configuration is programmed
to a highest bank bit of 16 as 0x3 translates to 16 and not 14.

Fix the highest bank bit field used for the SSPP to match the mdss
and gpu settings.

Fixes: 6f410b246209 ("drm/msm/mdss: populate missing data")
Reviewed-by: Rob Clark <robdclark@gmail.com>
Tested-by: Stephen Boyd <swboyd@chromium.org> # Trogdor.Lazor
Patchwork: https://patchwork.freedesktop.org/patch/607625/
Link: https://lore.kernel.org/r/20240808235227.2701479-1-quic_abhinavk@quicinc.com
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/msm/msm_mdss.c

index fab6ad4e5107c9576481d918aad692f01cb05b61..ec75274178028e7615607199a2d2bf15b2e5f930 100644 (file)
@@ -577,7 +577,7 @@ static const struct msm_mdss_data sc7180_data = {
        .ubwc_enc_version = UBWC_2_0,
        .ubwc_dec_version = UBWC_2_0,
        .ubwc_static = 0x1e,
-       .highest_bank_bit = 0x3,
+       .highest_bank_bit = 0x1,
        .reg_bus_bw = 76800,
 };