]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: enetc: do not allow VF to configure the RSS key
authorWei Fang <wei.fang@nxp.com>
Thu, 26 Mar 2026 07:52:33 +0000 (15:52 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 28 Mar 2026 03:56:46 +0000 (20:56 -0700)
VFs do not have privilege to configure the RSS key because the registers
are owned by the PF. Currently, if VF attempts to configure the RSS key,
enetc_set_rxfh() simply skips the configuration and does not generate a
warning, which may mislead users into thinking the feature is supported.
To improve this situation, add a check to reject RSS key configuration
on VFs.

Fixes: d382563f541b ("enetc: Add RFS and RSS support")
Signed-off-by: Wei Fang <wei.fang@nxp.com>
Reviewed-by: Clark Wang <xiaoning.wang@nxp.com>
Reviewed-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Link: https://patch.msgid.link/20260326075233.3628047-3-wei.fang@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/enetc/enetc_ethtool.c

index a393647e6062cb3f00daa24f78811fef5ecdf76e..7c17acaf7a380b1d4a1cf0911e04fa83fdebaf66 100644 (file)
@@ -800,8 +800,12 @@ static int enetc_set_rxfh(struct net_device *ndev,
                return -EOPNOTSUPP;
 
        /* set hash key, if PF */
-       if (rxfh->key && enetc_si_is_pf(si))
+       if (rxfh->key) {
+               if (!enetc_si_is_pf(si))
+                       return -EOPNOTSUPP;
+
                enetc_set_rss_key(si, rxfh->key);
+       }
 
        /* set RSS table */
        if (rxfh->indir)