lib: Simplify smbconf_txt_load_file()

file_modtime() returns errno, so we can skip the racy file_exist()
call.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>

diff --git a/lib/smbconf/smbconf_txt.c b/lib/smbconf/smbconf_txt.c
index 70a35ec43049a4f4147bd9dc7248cea0ed01ade9..f090430b3486ac957bf8b4a9c48d35f4b9f8cdf6 100644 (file)
--- a/lib/smbconf/smbconf_txt.c
+++ b/lib/smbconf/smbconf_txt.c
@@ -187,12 +187,12 @@ static sbcErr smbconf_txt_load_file(struct smbconf_ctx *ctx)
        int rc;
        struct timespec mt = {0};
 
-       if (!file_exist(ctx->path)) {
-               return SBC_ERR_BADFILE;
-       }
-
        rc = file_modtime(ctx->path, &mt);
        if (rc != 0) {
+               if (rc == ENOENT) {
+                       return SBC_ERR_BADFILE;
+               }
+
                /*
                 * Not worth mapping errno returned
                 * in rc to SBC_ERR_XXX. Just assume