]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mei: me: release irq in mei_me_pci_resume error path
authorTomas Winkler <tomas.winkler@intel.com>
Tue, 4 Jun 2024 09:07:28 +0000 (12:07 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Jul 2024 07:08:15 +0000 (09:08 +0200)
commit 283cb234ef95d94c61f59e1cd070cd9499b51292 upstream.

The mei_me_pci_resume doesn't release irq on the error path,
in case mei_start() fails.

Cc: <stable@kernel.org>
Fixes: 33ec08263147 ("mei: revamp mei reset state machine")
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Link: https://lore.kernel.org/r/20240604090728.1027307-1-tomas.winkler@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mei/pci-me.c

index d7233f2238651ff9e34c505d4b61630e78538e8e..8cd9830b97a378eba7d6cf19b01ed2b4cd857ac8 100644 (file)
@@ -379,8 +379,10 @@ static int mei_me_pci_resume(struct device *device)
        }
 
        err = mei_restart(dev);
-       if (err)
+       if (err) {
+               free_irq(pdev->irq, dev);
                return err;
+       }
 
        /* Start timer if stopped in suspend */
        schedule_delayed_work(&dev->timer_work, HZ);