Issue #13874: read_null() of faulthandler uses volatile to avoid optimisation

Clang 3.0 removes "y = *x;" instruction if the optimisation level is 3.

diff --git a/Modules/faulthandler.c b/Modules/faulthandler.c
index fcf4d0123910cd25a4b059ffb567f458832588cb..f18bbbc44ff3cefe13b30ff07fc5e4a294bca69b 100644 (file)
--- a/Modules/faulthandler.c
+++ b/Modules/faulthandler.c
@@ -943,10 +943,13 @@ faulthandler_unregister_py(PyObject *self, PyObject *args)
 static PyObject *
 faulthandler_read_null(PyObject *self, PyObject *args)
 {
-    int *x = NULL, y;
+    volatile int *x;
+    volatile int y;
     int release_gil = 0;
     if (!PyArg_ParseTuple(args, "|i:_read_null", &release_gil))
         return NULL;
+
+    x = NULL;
     if (release_gil) {
         Py_BEGIN_ALLOW_THREADS
         y = *x;