]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
python/samba/netcmd: Fix NameError exception
authorNoel Power <noel.power@suse.com>
Wed, 13 Jun 2018 11:51:50 +0000 (12:51 +0100)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 20 Jun 2018 02:08:53 +0000 (04:08 +0200)
Running make test TEST=samba4.drs.samba_tool_drs.python results in

BlackboxProcessError: Command '/tmp/samba-testbase/b12/samba/bin/samba-tool drs clone-dc-database samba.example.com --server=localdc -USAMBADOMAIN/Administrator%locDCpass1 --targetdir=/tmp/samba-testbase/b12/samba/bin/ab/tmp/tmpWPo8r3'; exit status 255; stdout: ''; stderr: 'ERROR(<type 'exceptions.NameError'>): uncaught exception - global name 'logging' is not defined
  File "bin/python/samba/netcmd/__init__.py", line 177, in _run
    return self.run(*args, **kwargs)
  File "bin/python/samba/netcmd/drs.py", line 697, in run
    logger.setLevel(logging.INFO)
'

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jun 20 04:08:53 CEST 2018 on sn-devel-144

python/samba/netcmd/drs.py

index 45ec8f539a316247f059c15fc18d0fa43bf46682..235d82b4484f6ff853f13e24bb3c007589195505 100644 (file)
@@ -38,6 +38,7 @@ from samba.dcerpc import drsuapi, misc
 from samba.join import join_clone
 from samba.ndr import ndr_unpack
 from samba.dcerpc import drsblobs
+import logging
 
 def drsuapi_connect(ctx):
     '''make a DRSUAPI connection to the server'''