]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
hwmon: Add LattePanda Sigma EC driver
authorMariano Abad <weimaraner@gmail.com>
Tue, 3 Mar 2026 00:46:04 +0000 (21:46 -0300)
committerGuenter Roeck <linux@roeck-us.net>
Tue, 31 Mar 2026 02:45:05 +0000 (19:45 -0700)
Add hardware monitoring support for the LattePanda Sigma SBC
(DFRobot, ITE IT8613E EC). The driver reads fan speed and
temperatures via direct port I/O, as the BIOS disables the
ACPI EC interface.

Signed-off-by: Mariano Abad <weimaraner@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Documentation/hwmon/index.rst
Documentation/hwmon/lattepanda-sigma-ec.rst [new file with mode: 0644]
MAINTAINERS
drivers/hwmon/Kconfig
drivers/hwmon/Makefile
drivers/hwmon/lattepanda-sigma-ec.c [new file with mode: 0644]

index c7ba1cc86882d70830a2ce23e646b311dba08b7f..559c32344cd38a9b5bf01a0b7570213f5ae1ab8b 100644 (file)
@@ -110,6 +110,7 @@ Hardware Monitoring Kernel Drivers
    kbatt
    kfan
    lan966x
+   lattepanda-sigma-ec
    lineage-pem
    lm25066
    lm63
diff --git a/Documentation/hwmon/lattepanda-sigma-ec.rst b/Documentation/hwmon/lattepanda-sigma-ec.rst
new file mode 100644 (file)
index 0000000..8a521ee
--- /dev/null
@@ -0,0 +1,61 @@
+.. SPDX-License-Identifier: GPL-2.0-or-later
+
+Kernel driver lattepanda-sigma-ec
+=================================
+
+Supported systems:
+
+  * LattePanda Sigma (Intel 13th Gen i5-1340P)
+
+    DMI vendor: LattePanda
+
+    DMI product: LattePanda Sigma
+
+    BIOS version: 5.27 (verified)
+
+    Datasheet: Not available (EC registers discovered empirically)
+
+Author: Mariano Abad <weimaraner@gmail.com>
+
+Description
+-----------
+
+This driver provides hardware monitoring for the LattePanda Sigma
+single-board computer made by DFRobot. The board uses an ITE IT8613E
+Embedded Controller to manage a CPU cooling fan and thermal sensors.
+
+The BIOS declares the ACPI Embedded Controller (``PNP0C09``) with
+``_STA`` returning 0, preventing the kernel's ACPI EC subsystem from
+initializing. This driver reads the EC directly via the standard ACPI
+EC I/O ports (``0x62`` data, ``0x66`` command/status).
+
+Sysfs attributes
+----------------
+
+======================= ===============================================
+``fan1_input``          Fan speed in RPM (EC registers 0x2E:0x2F,
+                        16-bit big-endian)
+``fan1_label``          "CPU Fan"
+``temp1_input``         Board/ambient temperature in millidegrees
+                        Celsius (EC register 0x60, unsigned)
+``temp1_label``         "Board Temp"
+``temp2_input``         CPU proximity temperature in millidegrees
+                        Celsius (EC register 0x70, unsigned)
+``temp2_label``         "CPU Temp"
+======================= ===============================================
+
+Module parameters
+-----------------
+
+``force`` (bool, default false)
+    Force loading on BIOS versions other than 5.27. The driver still
+    requires DMI vendor and product name matching.
+
+Known limitations
+-----------------
+
+* Fan speed control is not supported. The fan is always under EC
+  automatic control.
+* The EC register map was verified only on BIOS version 5.27.
+  Other versions may use different register offsets; use the ``force``
+  parameter at your own risk.
index c3fe46d7c4bc43e960282537a7d89fd4c34080f7..1c49613b142ecfeb321ffe08dce76e4201879093 100644 (file)
@@ -14421,6 +14421,13 @@ F:     drivers/net/wan/framer/
 F:     drivers/pinctrl/pinctrl-pef2256.c
 F:     include/linux/framer/
 
+LATTEPANDA SIGMA EC HARDWARE MONITOR DRIVER
+M:     Mariano Abad <weimaraner@gmail.com>
+L:     linux-hwmon@vger.kernel.org
+S:     Maintained
+F:     Documentation/hwmon/lattepanda-sigma-ec.rst
+F:     drivers/hwmon/lattepanda-sigma-ec.c
+
 LASI 53c700 driver for PARISC
 M:     "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
 L:     linux-scsi@vger.kernel.org
index f034d204be4fd3dbbc4ec1c0db9fa43808f7e3bb..e0cd83b4b715d389f998101ac343b880a0c687c6 100644 (file)
@@ -964,6 +964,23 @@ config SENSORS_LAN966X
          This driver can also be built as a module. If so, the module
          will be called lan966x-hwmon.
 
+config SENSORS_LATTEPANDA_SIGMA_EC
+       tristate "LattePanda Sigma EC hardware monitoring"
+       depends on X86
+       depends on DMI
+       depends on HAS_IOPORT
+       help
+         If you say yes here you get support for the hardware monitoring
+         features of the Embedded Controller on LattePanda Sigma
+         single-board computers, including CPU fan speed (RPM) and
+         board and CPU temperatures.
+
+         The driver reads the EC directly via ACPI EC I/O ports and
+         uses DMI matching to ensure it only loads on supported hardware.
+
+         This driver can also be built as a module. If so, the module
+         will be called lattepanda-sigma-ec.
+
 config SENSORS_LENOVO_EC
         tristate "Sensor reader for Lenovo ThinkStations"
         depends on X86
index c1020dbbc1ac6078d12d0a608db7614edaca996e..556e86d277b195d8c98798012f0069c78a2f37dc 100644 (file)
@@ -113,6 +113,7 @@ obj-$(CONFIG_SENSORS_K10TEMP)       += k10temp.o
 obj-$(CONFIG_SENSORS_KBATT)    += kbatt.o
 obj-$(CONFIG_SENSORS_KFAN)     += kfan.o
 obj-$(CONFIG_SENSORS_LAN966X)  += lan966x-hwmon.o
+obj-$(CONFIG_SENSORS_LATTEPANDA_SIGMA_EC) += lattepanda-sigma-ec.o
 obj-$(CONFIG_SENSORS_LENOVO_EC)        += lenovo-ec-sensors.o
 obj-$(CONFIG_SENSORS_LINEAGE)  += lineage-pem.o
 obj-$(CONFIG_SENSORS_LOCHNAGAR)        += lochnagar-hwmon.o
diff --git a/drivers/hwmon/lattepanda-sigma-ec.c b/drivers/hwmon/lattepanda-sigma-ec.c
new file mode 100644 (file)
index 0000000..f060974
--- /dev/null
@@ -0,0 +1,359 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Hardware monitoring driver for LattePanda Sigma EC.
+ *
+ * The LattePanda Sigma is an x86 SBC made by DFRobot with an ITE IT8613E
+ * Embedded Controller that manages a CPU fan and thermal sensors.
+ *
+ * The BIOS declares the ACPI Embedded Controller (PNP0C09) with _STA
+ * returning 0 and provides only stub ECRD/ECWT methods that return Zero
+ * for all registers. Since the kernel's ACPI EC subsystem never initializes,
+ * ec_read() is not available and direct port I/O to the standard ACPI EC
+ * ports (0x62/0x66) is used instead.
+ *
+ * Because ACPI never initializes the EC, there is no concurrent firmware
+ * access to these ports, and no ACPI Global Lock or namespace mutex is
+ * required. The hwmon with_info API serializes all sysfs callbacks,
+ * so no additional driver-level locking is needed.
+ *
+ * The EC register map was discovered by dumping all 256 registers,
+ * identifying those that change in real-time, and validating by physically
+ * stopping the fan and observing the RPM register drop to zero. The map
+ * has been verified on BIOS version 5.27; other versions may differ.
+ *
+ * Copyright (c) 2026 Mariano Abad <weimaraner@gmail.com>
+ */
+
+#include <linux/delay.h>
+#include <linux/dmi.h>
+#include <linux/hwmon.h>
+#include <linux/io.h>
+#include <linux/ioport.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+
+#define DRIVER_NAME    "lattepanda_sigma_ec"
+
+/* EC I/O ports (standard ACPI EC interface) */
+#define EC_DATA_PORT   0x62
+#define EC_CMD_PORT    0x66    /* also status port */
+
+/* EC commands */
+#define EC_CMD_READ    0x80
+
+/* EC status register bits */
+#define EC_STATUS_OBF  0x01    /* Output Buffer Full */
+#define EC_STATUS_IBF  0x02    /* Input Buffer Full */
+
+/* EC register offsets for LattePanda Sigma (BIOS 5.27) */
+#define EC_REG_FAN_RPM_HI      0x2E
+#define EC_REG_FAN_RPM_LO      0x2F
+#define EC_REG_TEMP_BOARD      0x60
+#define EC_REG_TEMP_CPU                0x70
+#define EC_REG_FAN_DUTY                0x93
+
+/*
+ * EC polling uses udelay() because the EC typically responds within a
+ * few microseconds. The kernel's own ACPI EC driver (drivers/acpi/ec.c)
+ * likewise uses udelay() for busy-polling with a per-poll delay of 550us.
+ *
+ * usleep_range() was tested but caused EC protocol failures: the EC
+ * clears its status flags within microseconds, and sleeping for 50-100us
+ * between polls allowed the flags to transition past the expected state.
+ *
+ * The worst-case total busy-wait of 25ms covers EC recovery after errors.
+ * In practice the EC responds within 10us so the loop exits immediately.
+ */
+#define EC_TIMEOUT_US          25000
+#define EC_POLL_US             1
+
+static bool force;
+module_param(force, bool, 0444);
+MODULE_PARM_DESC(force,
+                "Force loading on untested BIOS versions (default: false)");
+
+static struct platform_device *lps_ec_pdev;
+
+static int ec_wait_ibf_clear(void)
+{
+       int i;
+
+       for (i = 0; i < EC_TIMEOUT_US; i++) {
+               if (!(inb(EC_CMD_PORT) & EC_STATUS_IBF))
+                       return 0;
+               udelay(EC_POLL_US);
+       }
+       return -ETIMEDOUT;
+}
+
+static int ec_wait_obf_set(void)
+{
+       int i;
+
+       for (i = 0; i < EC_TIMEOUT_US; i++) {
+               if (inb(EC_CMD_PORT) & EC_STATUS_OBF)
+                       return 0;
+               udelay(EC_POLL_US);
+       }
+       return -ETIMEDOUT;
+}
+
+static int ec_read_reg(u8 reg, u8 *val)
+{
+       int ret;
+
+       ret = ec_wait_ibf_clear();
+       if (ret)
+               return ret;
+
+       outb(EC_CMD_READ, EC_CMD_PORT);
+
+       ret = ec_wait_ibf_clear();
+       if (ret)
+               return ret;
+
+       outb(reg, EC_DATA_PORT);
+
+       ret = ec_wait_obf_set();
+       if (ret)
+               return ret;
+
+       *val = inb(EC_DATA_PORT);
+       return 0;
+}
+
+/*
+ * Read a 16-bit big-endian value from two consecutive EC registers.
+ *
+ * The EC may update the register pair between reading the high and low
+ * bytes, which could produce a corrupted value if the high byte rolls
+ * over (e.g., 0x0100 -> 0x00FF read as 0x01FF). Guard against this by
+ * re-reading the high byte after reading the low byte. If the high byte
+ * changed, re-read the low byte to get a consistent pair.
+ * See also lm90_read16() which uses the same approach.
+ */
+static int ec_read_reg16(u8 reg_hi, u8 reg_lo, u16 *val)
+{
+       int ret;
+       u8 oldh, newh, lo;
+
+       ret = ec_read_reg(reg_hi, &oldh);
+       if (ret)
+               return ret;
+
+       ret = ec_read_reg(reg_lo, &lo);
+       if (ret)
+               return ret;
+
+       ret = ec_read_reg(reg_hi, &newh);
+       if (ret)
+               return ret;
+
+       if (oldh != newh) {
+               ret = ec_read_reg(reg_lo, &lo);
+               if (ret)
+                       return ret;
+       }
+
+       *val = ((u16)newh << 8) | lo;
+       return 0;
+}
+
+static int
+lps_ec_read_string(struct device *dev,
+                  enum hwmon_sensor_types type,
+                  u32 attr, int channel,
+                  const char **str)
+{
+       switch (type) {
+       case hwmon_fan:
+               *str = "CPU Fan";
+               return 0;
+       case hwmon_temp:
+               *str = channel == 0 ? "Board Temp" : "CPU Temp";
+               return 0;
+       default:
+               return -EOPNOTSUPP;
+       }
+}
+
+static umode_t
+lps_ec_is_visible(const void *drvdata,
+                 enum hwmon_sensor_types type,
+                 u32 attr, int channel)
+{
+       switch (type) {
+       case hwmon_fan:
+               if (attr == hwmon_fan_input || attr == hwmon_fan_label)
+                       return 0444;
+               break;
+       case hwmon_temp:
+               if (attr == hwmon_temp_input || attr == hwmon_temp_label)
+                       return 0444;
+               break;
+       default:
+               break;
+       }
+       return 0;
+}
+
+static int
+lps_ec_read(struct device *dev,
+           enum hwmon_sensor_types type,
+           u32 attr, int channel, long *val)
+{
+       u16 rpm;
+       u8 v;
+       int ret;
+
+       switch (type) {
+       case hwmon_fan:
+               if (attr != hwmon_fan_input)
+                       return -EOPNOTSUPP;
+               ret = ec_read_reg16(EC_REG_FAN_RPM_HI,
+                                   EC_REG_FAN_RPM_LO, &rpm);
+               if (ret)
+                       return ret;
+               *val = rpm;
+               return 0;
+
+       case hwmon_temp:
+               if (attr != hwmon_temp_input)
+                       return -EOPNOTSUPP;
+               ret = ec_read_reg(channel == 0 ? EC_REG_TEMP_BOARD
+                                              : EC_REG_TEMP_CPU,
+                                 &v);
+               if (ret)
+                       return ret;
+               /* EC reports unsigned 8-bit temperature in degrees Celsius */
+               *val = (unsigned long)v * 1000;
+               return 0;
+
+       default:
+               return -EOPNOTSUPP;
+       }
+}
+
+static const struct hwmon_channel_info * const lps_ec_info[] = {
+       HWMON_CHANNEL_INFO(fan, HWMON_F_INPUT | HWMON_F_LABEL),
+       HWMON_CHANNEL_INFO(temp,
+                          HWMON_T_INPUT | HWMON_T_LABEL,
+                          HWMON_T_INPUT | HWMON_T_LABEL),
+       NULL
+};
+
+static const struct hwmon_ops lps_ec_ops = {
+       .is_visible = lps_ec_is_visible,
+       .read = lps_ec_read,
+       .read_string = lps_ec_read_string,
+};
+
+static const struct hwmon_chip_info lps_ec_chip_info = {
+       .ops = &lps_ec_ops,
+       .info = lps_ec_info,
+};
+
+static int lps_ec_probe(struct platform_device *pdev)
+{
+       struct device *dev = &pdev->dev;
+       struct device *hwmon;
+       u8 test;
+       int ret;
+
+       if (!devm_request_region(dev, EC_DATA_PORT, 1, DRIVER_NAME))
+               return dev_err_probe(dev, -EBUSY,
+                                    "Failed to request EC data port 0x%x\n",
+                                    EC_DATA_PORT);
+
+       if (!devm_request_region(dev, EC_CMD_PORT, 1, DRIVER_NAME))
+               return dev_err_probe(dev, -EBUSY,
+                                    "Failed to request EC cmd port 0x%x\n",
+                                    EC_CMD_PORT);
+
+       /* Sanity check: verify EC is responsive */
+       ret = ec_read_reg(EC_REG_FAN_DUTY, &test);
+       if (ret)
+               return dev_err_probe(dev, ret,
+                                    "EC not responding on ports 0x%x/0x%x\n",
+                                    EC_DATA_PORT, EC_CMD_PORT);
+
+       hwmon = devm_hwmon_device_register_with_info(dev, DRIVER_NAME, NULL,
+                                                    &lps_ec_chip_info, NULL);
+       if (IS_ERR(hwmon))
+               return dev_err_probe(dev, PTR_ERR(hwmon),
+                                    "Failed to register hwmon device\n");
+
+       dev_info(dev, "EC hwmon registered (fan duty: %u%%)\n", test);
+       return 0;
+}
+
+/* DMI table with strict BIOS version match (override with force=1) */
+static const struct dmi_system_id lps_ec_dmi_table[] = {
+       {
+               .ident = "LattePanda Sigma",
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "LattePanda"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "LattePanda Sigma"),
+                       DMI_MATCH(DMI_BIOS_VERSION, "5.27"),
+               },
+       },
+       { }     /* terminator */
+};
+MODULE_DEVICE_TABLE(dmi, lps_ec_dmi_table);
+
+/* Loose table (vendor + product only) for use with force=1 */
+static const struct dmi_system_id lps_ec_dmi_table_force[] = {
+       {
+               .ident = "LattePanda Sigma",
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "LattePanda"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "LattePanda Sigma"),
+               },
+       },
+       { }     /* terminator */
+};
+
+static struct platform_driver lps_ec_driver = {
+       .probe  = lps_ec_probe,
+       .driver = {
+               .name = DRIVER_NAME,
+       },
+};
+
+static int __init lps_ec_init(void)
+{
+       int ret;
+
+       if (!dmi_check_system(lps_ec_dmi_table)) {
+               if (!force || !dmi_check_system(lps_ec_dmi_table_force))
+                       return -ENODEV;
+               pr_warn("%s: BIOS version not verified, loading due to force=1\n",
+                       DRIVER_NAME);
+       }
+
+       ret = platform_driver_register(&lps_ec_driver);
+       if (ret)
+               return ret;
+
+       lps_ec_pdev = platform_device_register_simple(DRIVER_NAME, -1,
+                                                     NULL, 0);
+       if (IS_ERR(lps_ec_pdev)) {
+               platform_driver_unregister(&lps_ec_driver);
+               return PTR_ERR(lps_ec_pdev);
+       }
+
+       return 0;
+}
+
+static void __exit lps_ec_exit(void)
+{
+       platform_device_unregister(lps_ec_pdev);
+       platform_driver_unregister(&lps_ec_driver);
+}
+
+module_init(lps_ec_init);
+module_exit(lps_ec_exit);
+
+MODULE_AUTHOR("Mariano Abad <weimaraner@gmail.com>");
+MODULE_DESCRIPTION("Hardware monitoring driver for LattePanda Sigma EC");
+MODULE_LICENSE("GPL");