]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-sasl: sasl-server-request - Assert that client input is only NULL when size is 0
authorStephan Bosch <stephan.bosch@open-xchange.com>
Thu, 9 Oct 2025 22:43:51 +0000 (00:43 +0200)
committerStephan Bosch <stephan.bosch@open-xchange.com>
Thu, 9 Oct 2025 23:37:11 +0000 (01:37 +0200)
Fix for scan-build report.

src/lib-sasl/sasl-server-request.c

index da65b86df3a3a6202ab4e3410da13e7a2034f3d1..6656fd216ff42686ee3f9bc3b499f177635c8712 100644 (file)
@@ -163,6 +163,8 @@ void sasl_server_request_initial(struct sasl_server_req_ctx *rctx,
        struct sasl_server_mech_request *mreq = req->mech;
        const struct sasl_server_mech *mech = mreq->mech;
 
+       i_assert(data != NULL || data_size == 0);
+
        if (data == NULL) {
                e_debug(req->event,
                        "Started interaction without initial response");
@@ -191,6 +193,8 @@ void sasl_server_request_input(struct sasl_server_req_ctx *rctx,
        struct sasl_server_mech_request *mreq = req->mech;
        const struct sasl_server_mech *mech = mreq->mech;
 
+       i_assert(data != NULL || data_size == 0);
+
        e_debug(req->event,
                "Client continued interaction with response (size=%zu)",
                data_size);