2009-12-22 Vladimir Serbinenko <phcoder@gmail.com>

	* commands/memrw.c (cmd_read_byte, cmd_read_word, cmd_read_dword):
	Use grub_extcmd_t. All users updated.
	(options): New variable.
	(grub_cmd_read): Restructure for readability. Support "-v" option.
	(grub_cmd_write): Restructure for readability.

diff --git a/ChangeLog b/ChangeLog
index 56c660494425806bee6ecad42b55b844d8d04b20..0e2320e29d490dc5fb93303b51e5b72498d8d81f 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2009-12-22  Vladimir Serbinenko  <phcoder@gmail.com>
+
+       * commands/memrw.c (cmd_read_byte, cmd_read_word, cmd_read_dword):
+       Use grub_extcmd_t. All users updated.
+       (options): New variable.
+       (grub_cmd_read): Restructure for readability. Support "-v" option.
+       (grub_cmd_write): Restructure for readability.
+
 2009-12-22 Felix Zielcke <fzielcke@z-51.de>
 
        * genmk.rb (class SCRIPT): Prepend #{src} path with $(srcdir).

diff --git a/commands/memrw.c b/commands/memrw.c
index f43380f041e66504cf936ea9e8a011675f6c8fc1..8543cadfa0a5e98baab48ff0f8ccd05f3d2241c1 100644 (file)
--- a/commands/memrw.c
+++ b/commands/memrw.c
@@ -19,29 +19,53 @@
 
 #include <grub/dl.h>
 #include <grub/misc.h>
-#include <grub/command.h>
+#include <grub/extcmd.h>
+#include <grub/env.h>
 
-static grub_command_t cmd_read_byte, cmd_read_word, cmd_read_dword;
+static grub_extcmd_t cmd_read_byte, cmd_read_word, cmd_read_dword;
 static grub_command_t cmd_write_byte, cmd_write_word, cmd_write_dword;
 
+static const struct grub_arg_option options[] =
+  {
+    {0, 'v', 0, "Save read value into variable VARNAME.",
+     "VARNAME", ARG_TYPE_STRING},
+    {0, 0, 0, 0, 0, 0}
+  };
+
+
 static grub_err_t
-grub_cmd_read (grub_command_t cmd, int argc, char **argv)
+grub_cmd_read (grub_extcmd_t cmd, int argc, char **argv)
 {
   grub_target_addr_t addr;
-  grub_uint32_t value;
+  grub_uint32_t value = 0;
+  char buf[sizeof ("XXXXXXXX")];
 
   if (argc != 1)
     return grub_error (GRUB_ERR_BAD_ARGUMENT, "Invalid number of arguments");
 
   addr = grub_strtoul (argv[0], 0, 0);
-  if (cmd->name[5] == 'd')
-    value = *((grub_uint32_t *) addr);
-  else if (cmd->name[5] == 'w')
-    value = *((grub_uint16_t *) addr);
-  else
-    value = *((grub_uint8_t *) addr);
+  switch (cmd->cmd->name[sizeof ("read_") - 1])
+    {
+    case 'd':
+      value = *((volatile grub_uint32_t *) addr);
+      break;
+
+    case 'w':
+      value = *((volatile grub_uint16_t *) addr);
+      break;
 
-  grub_printf ("0x%x\n", value);
+    case 'b':
+      value = *((volatile grub_uint8_t *) addr);
+      break;
+    }
+
+  if (cmd->state[0].set)
+    {
+      grub_sprintf (buf, "%x", value);
+      grub_env_set (cmd->state[0].arg, buf);
+    }
+  else
+    grub_printf ("0x%x\n", value);
 
   return 0;
 }
@@ -57,12 +81,20 @@ grub_cmd_write (grub_command_t cmd, int argc, char **argv)
 
   addr = grub_strtoul (argv[0], 0, 0);
   value = grub_strtoul (argv[1], 0, 0);
-  if (cmd->name[6] == 'd')
-    *((grub_uint32_t *) addr) = value;
-  else if (cmd->name[6] == 'w')
-    *((grub_uint16_t *) addr) = (grub_uint16_t) value;
-  else
-    *((grub_uint8_t *) addr) = (grub_uint8_t) value;
+  switch (cmd->name[sizeof ("write_") - 1])
+    {
+    case 'd':
+      *((volatile grub_uint32_t *) addr) = value;
+      break;
+
+    case 'w':
+      *((volatile grub_uint16_t *) addr) = (grub_uint16_t) value;
+      break;
+
+    case 'b':
+      *((volatile grub_uint8_t *) addr) = (grub_uint8_t) value;
+      break;
+    }
 
   return 0;
 }
@@ -70,14 +102,14 @@ grub_cmd_write (grub_command_t cmd, int argc, char **argv)
 GRUB_MOD_INIT(memrw)
 {
   cmd_read_byte =
-    grub_register_command ("read_byte", grub_cmd_read,
-                          "read_byte ADDR", "Read byte from ADDR.");
+    grub_register_extcmd ("read_byte", grub_cmd_read, GRUB_COMMAND_FLAG_BOTH,
+                         "read_byte ADDR", "Read byte from ADDR.", options);
   cmd_read_word =
-    grub_register_command ("read_word", grub_cmd_read,
-                          "read_word ADDR", "Read word from ADDR.");
+    grub_register_extcmd ("read_word", grub_cmd_read, GRUB_COMMAND_FLAG_BOTH,
+                         "read_word ADDR", "Read word from ADDR.", options);
   cmd_read_dword =
-    grub_register_command ("read_dword", grub_cmd_read,
-                          "read_dword ADDR", "Read dword from ADDR.");
+    grub_register_extcmd ("read_dword", grub_cmd_read, GRUB_COMMAND_FLAG_BOTH,
+                         "read_dword ADDR", "Read dword from ADDR.", options);
   cmd_write_byte =
     grub_register_command ("write_byte", grub_cmd_write,
                           "write_byte ADDR VALUE", "Write byte VALUE to ADDR.");
@@ -91,9 +123,9 @@ GRUB_MOD_INIT(memrw)
 
 GRUB_MOD_FINI(memrw)
 {
-  grub_unregister_command (cmd_read_byte);
-  grub_unregister_command (cmd_read_word);
-  grub_unregister_command (cmd_read_dword);
+  grub_unregister_extcmd (cmd_read_byte);
+  grub_unregister_extcmd (cmd_read_word);
+  grub_unregister_extcmd (cmd_read_dword);
   grub_unregister_command (cmd_write_byte);
   grub_unregister_command (cmd_write_word);
   grub_unregister_command (cmd_write_dword);