]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
udev-event: add more assert()
authorYu Watanabe <watanabe.yu+github@gmail.com>
Wed, 24 Oct 2018 21:39:48 +0000 (06:39 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 26 Oct 2018 22:03:39 +0000 (07:03 +0900)
src/udev/udev-event.c

index 125b4005b1a3fb434224dfaf03f528d0e32640f7..182fb03ada3dfbfc96ca0f16ad4acf1dc7cbe7d2 100644 (file)
@@ -86,9 +86,10 @@ enum subst_type {
         SUBST_SYS,
 };
 
-static size_t subst_format_var(struct udev_event *event, struct udev_device *dev,
+static size_t subst_format_var(struct udev_event *event,
                                enum subst_type type, char *attr,
                                char *dest, size_t l) {
+        struct udev_device *dev = event->dev;
         char *s = dest;
 
         switch (type) {
@@ -282,7 +283,6 @@ static size_t subst_format_var(struct udev_event *event, struct udev_device *dev
 size_t udev_event_apply_format(struct udev_event *event,
                                const char *src, char *dest, size_t size,
                                bool replace_whitespace) {
-        struct udev_device *dev = event->dev;
         static const struct subst_map {
                 const char *name;
                 const char fmt;
@@ -311,7 +311,11 @@ size_t udev_event_apply_format(struct udev_event *event,
         char *s;
         size_t l;
 
-        assert(dev);
+        assert(event);
+        assert(event->dev);
+        assert(src);
+        assert(dest);
+        assert(size > 0);
 
         from = src;
         s = dest;
@@ -390,7 +394,7 @@ subst:
                         attr = NULL;
                 }
 
-                subst_len = subst_format_var(event, dev, type, attr, s, l);
+                subst_len = subst_format_var(event, type, attr, s, l);
 
                 /* SUBST_RESULT handles spaces itself */
                 if (replace_whitespace && type != SUBST_RESULT)