Coverity scan found a few bad lines.

diff --git a/src/client_side.cc b/src/client_side.cc
index 6f5cc255f42311dd8d1cfb3d602c928ee9a9e76c..89583cb6b74a725cfc99b76e6441904c4cfebdc1 100644 (file)
--- a/src/client_side.cc
+++ b/src/client_side.cc
@@ -533,7 +533,8 @@ ClientHttpRequest::logRequest()
             checklist->reply = HTTPMSGLOCK(al.reply);
 
         if (!Config.accessList.log || checklist->fastCheck()) {
-            al.request = HTTPMSGLOCK(request);
+            if(request)
+                al.request = HTTPMSGLOCK(request);
             accessLogLog(&al, checklist);
             updateCounters();
 

diff --git a/src/ipcache.cc b/src/ipcache.cc
index f95c7f7b69b7b682ffc5c2982b8eb84c14687d5a..4a57e2ef91f94aa8c9b800ecb6d3b46539be6947 100644 (file)
--- a/src/ipcache.cc
+++ b/src/ipcache.cc
@@ -855,11 +855,11 @@ static void
 ipcacheStatPrint(ipcache_entry * i, StoreEntry * sentry)
 {
     int k;
-    int count = i->addrs.count;
     char buf[MAX_IPSTRLEN];
 
     if (!sentry) {
         debugs(14, 0, HERE << "CRITICAL: sentry is NULL!");
+        return;
     }
 
     if (!i) {
@@ -868,6 +868,8 @@ ipcacheStatPrint(ipcache_entry * i, StoreEntry * sentry)
         return;
     }
 
+    int count = i->addrs.count;
+
     storeAppendPrintf(sentry, " %-32.32s %c%c %6d %6d %2d(%2d)",
                       hashKeyStr(&i->hash),
                       i->flags.fromhosts ? 'H' : ' ',

diff --git a/src/url.cc b/src/url.cc
index 9071695220b5f814a197cf88e7495a7ec4cd1528..84bb42eabf7bb3269f9c2dbd6a32b7c1576db589 100644 (file)
--- a/src/url.cc
+++ b/src/url.cc
@@ -248,7 +248,7 @@ urlParse(const HttpRequestMethod& method, char *url, HttpRequest *request)
 
         /* Then everything until first /; thats host (and port; which we'll look for here later) */
         /* bug 1881: If we don't get a "/" then we imply it was there */
-        for (dst = host; i < l && *src != '/' && src != '\0'; i++, src++, dst++) {
+        for (dst = host; i < l && *src != '/' && *src != '\0'; i++, src++, dst++) {
             *dst = *src;
         }