iputils: Make static addresses static in `ComboAddress::isUnspecified`

Prevent having to instantiate them again and again, as suggested by
Otto.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

diff --git a/pdns/iputils.hh b/pdns/iputils.hh
index c567f789503086372b5b72a4937a015b78e44e23..a533ab3c1b6ea9e57040ce0a535b1c278ebe26cf 100644 (file)
--- a/pdns/iputils.hh
+++ b/pdns/iputils.hh
@@ -286,9 +286,9 @@ union ComboAddress
 
   [[nodiscard]] bool isUnspecified() const
   {
+    static const ComboAddress unspecifiedV4("0.0.0.0:0");
+    static const ComboAddress unspecifiedV6("[::]:0");
     const auto compare = ComboAddress::addressOnlyEqual();
-    const ComboAddress unspecifiedV4("0.0.0.0:0");
-    const ComboAddress unspecifiedV6("[::]:0");
     return compare(*this, unspecifiedV4) || compare(*this, unspecifiedV6);
   }