Author: R Phillips <r.phillips@uq.edu.au>

Bug 2924: RADIUS helper compile issues

diff --git a/helpers/basic_auth/squid_radius_auth/radius-util.c b/helpers/basic_auth/squid_radius_auth/radius-util.c
index 4388dcc96e9740f53c893869fe91840444ec3ea8..29969ad5081387e58982c32c3d84da81ed71de8a 100644 (file)
--- a/helpers/basic_auth/squid_radius_auth/radius-util.c
+++ b/helpers/basic_auth/squid_radius_auth/radius-util.c
@@ -90,7 +90,7 @@ static int good_ipaddr(char *addr)
         if (*addr == '.') {
             dot_count++;
             digit_count = 0;
-        } else if (!isdigit(*addr)) {
+        } else if (!isdigit((int)*addr)) {
             dot_count = 5;
         } else {
             digit_count++;
@@ -126,7 +126,7 @@ static u_int32_t ipstr2long(char *ip_str)
         count = 0;
         *ptr = '\0';
         while (*ip_str != '.' && *ip_str != '\0' && count < 4) {
-            if (!isdigit(*ip_str)) {
+            if (!isdigit((int)*ip_str)) {
                 return((u_int32_t)0);
             }
             *ptr++ = *ip_str++;

diff --git a/helpers/basic_auth/squid_radius_auth/squid_rad_auth.c b/helpers/basic_auth/squid_radius_auth/squid_rad_auth.c
index 8e59ba464d7995fb7c0964631fc09fde31f23581..bc947148f277d86af65d1898192eb6f7b95da331 100644 (file)
--- a/helpers/basic_auth/squid_radius_auth/squid_rad_auth.c
+++ b/helpers/basic_auth/squid_radius_auth/squid_rad_auth.c
@@ -572,7 +572,7 @@ main(int argc, char **argv)
 
         /* Parse out the username and password */
         ptr = authstring;
-        while (isspace(*ptr))
+        while (isspace((int)*ptr))
             ptr++;
         if ((end = strchr(ptr, ' ')) == NULL) {
             printf("ERR\n");   /* No password */
@@ -581,7 +581,7 @@ main(int argc, char **argv)
         *end = '\0';
         urldecode(username, ptr, MAXPWNAM);
         ptr = end + 1;
-        while (isspace(*ptr))
+        while (isspace((int)*ptr))
             ptr++;
         urldecode(passwd, ptr, MAXPASS);