func_frame_drop: Handle allocation failure properly.

Handle allocation failure and simplify the allocation using asprintf.

Resolves: #1366
(cherry picked from commit 40e6f2b12cfaeddf57712586f40b1f90d658eba9)

diff --git a/funcs/func_frame_drop.c b/funcs/func_frame_drop.c
index 19694bc387780a94515521881b4d407d1eddcd95..0d679ad9fca606945e1ea2adb08b5700522f578f 100644 (file)
--- a/funcs/func_frame_drop.c
+++ b/funcs/func_frame_drop.c
@@ -234,8 +234,10 @@ static int frame_drop_helper(struct ast_channel *chan, const char *cmd, char *da
                framedata->list_type = TX;
        }
 
-       buffer = ast_malloc(sizeof(value) + 3); /* leading and trailing comma and null terminator */
-       snprintf(buffer, sizeof(value) + 2, ",%s,", value);
+       if (ast_asprintf(&buffer, ",%s,", value) < 0) {
+               ast_free(framedata);
+               return -1;
+       }
        for (i = 0; i < ARRAY_LEN(frametype2str); i++) {
                if (strcasestr(buffer, frametype2str[i].str)) {
                        framedata->values[i] = 1;