]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
remoteproc: imx_rproc: Check return value of regmap_attach_dev() in imx_rproc_mmio_de...
authorChen Ni <nichen@iscas.ac.cn>
Mon, 9 Feb 2026 05:14:07 +0000 (13:14 +0800)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Thu, 5 Mar 2026 17:22:04 +0000 (10:22 -0700)
Add error checking for regmap_attach_dev() call in
imx_rproc_mmio_detect_mode() function to ensure proper error
propagation.

Return the value of regmap_attach_dev() if it fails to prevent
proceeding with an incomplete regmap setup.

Suggested-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Fixes: e14168bf3493 ("remoteproc: imx_rproc: Simplify IMX_RPROC_MMIO switch case")
Link: https://lore.kernel.org/r/20260209051407.1467660-1-nichen@iscas.ac.cn
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/remoteproc/imx_rproc.c

index f5f916d6790519360f446f063e09d018c5654953..75baf905988b5b083a9525ff7f00d0f4eac367cd 100644 (file)
@@ -1007,7 +1007,11 @@ static int imx_rproc_mmio_detect_mode(struct rproc *rproc)
        }
 
        priv->regmap = regmap;
-       regmap_attach_dev(dev, regmap, &config);
+       ret = regmap_attach_dev(dev, regmap, &config);
+       if (ret) {
+               dev_err(dev, "regmap attach failed\n");
+               return ret;
+       }
 
        if (priv->gpr) {
                ret = regmap_read(priv->gpr, dcfg->gpr_reg, &val);