]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
network: refuse to configure link properties when in initialized state
authorYu Watanabe <watanabe.yu+github@gmail.com>
Mon, 28 Feb 2022 02:15:01 +0000 (11:15 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 11 Mar 2022 05:20:31 +0000 (14:20 +0900)
The condition should be satisfied only when users request to reconfigure
the link, and in that case, all request will be cancelled. Hence, it is
not necessary to process the request.

src/network/networkd-setlink.c

index a3b52dc8d248f4556ba455056f2ee2a59796bda0..47dc6720ac0124fc94ae8c17e2aacb328bee6375 100644 (file)
@@ -486,7 +486,7 @@ static int link_is_ready_to_set_link(Link *link, Request *req) {
 
         op = PTR_TO_INT(req->set_link_operation_ptr);
 
-        if (!IN_SET(link->state, LINK_STATE_INITIALIZED, LINK_STATE_CONFIGURING, LINK_STATE_CONFIGURED))
+        if (!IN_SET(link->state, LINK_STATE_CONFIGURING, LINK_STATE_CONFIGURED))
                 return false;
 
         switch (op) {
@@ -1017,7 +1017,7 @@ static int link_up_or_down(Link *link, bool up, Request *req) {
 static bool link_is_ready_to_activate(Link *link) {
         assert(link);
 
-        if (!IN_SET(link->state, LINK_STATE_INITIALIZED, LINK_STATE_CONFIGURING, LINK_STATE_CONFIGURED))
+        if (!IN_SET(link->state, LINK_STATE_CONFIGURING, LINK_STATE_CONFIGURED))
                 return false;
 
         if (link->set_link_messages > 0)