Add some assertions to try to catch #17752

diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c
index 30dcd13f4a32b78923389f8ec0318471d7cf36ed..7a2de296012a00a0ff1789e825120f980075225c 100644 (file)
--- a/src/or/connection_edge.c
+++ b/src/or/connection_edge.c
@@ -765,6 +765,7 @@ connection_ap_rescan_and_attach_pending(void)
       continue;
 
     entry_conn = TO_ENTRY_CONN(conn);
+    tor_assert(entry_conn);
     if (! smartlist_contains(pending_entry_connections, entry_conn)) {
       log_warn(LD_BUG, "Found a connection %p that was supposed to be "
                "in pending_entry_connections, but wasn't. No worries; "
@@ -798,6 +799,7 @@ connection_ap_attach_pending(int retry)
   SMARTLIST_FOREACH_BEGIN(pending_entry_connections,
                           entry_connection_t *, entry_conn) {
     connection_t *conn = ENTRY_TO_CONN(entry_conn);
+    tor_assert(conn && entry_conn);
     if (conn->marked_for_close) {
       SMARTLIST_DEL_CURRENT(pending_entry_connections, entry_conn);
       continue;