]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-sasl: sasl-server-mech-digest-md5 - Rename error return parameter of parse_digest...
authorStephan Bosch <stephan.bosch@open-xchange.com>
Wed, 19 Feb 2025 01:11:30 +0000 (02:11 +0100)
committertimo.sirainen <timo.sirainen@open-xchange.com>
Thu, 9 Oct 2025 08:41:22 +0000 (08:41 +0000)
src/lib-sasl/sasl-server-mech-digest-md5.c

index a140c0151d73098b468062b0977f0ce7419d3921..75043f1e24ab246da3d4d24ebcc1d9f629348a9f 100644 (file)
@@ -364,7 +364,7 @@ auth_handle_response(struct digest_auth_request *request,
 static bool
 parse_digest_response(struct digest_auth_request *request,
                      const unsigned char *data, size_t size,
-                     const char **error)
+                     const char **error_r)
 {
        struct sasl_server_mech_request *auth_request = &request->auth_request;
        char *copy, *key, *value;
@@ -385,11 +385,11 @@ parse_digest_response(struct digest_auth_request *request,
           authzid="authzid-value"
        */
 
-       *error = NULL;
+       *error_r = NULL;
        failed = FALSE;
 
        if (size == 0) {
-               *error = "Client sent no input";
+               *error_r = "Client sent no input";
                return FALSE;
        }
 
@@ -398,7 +398,8 @@ parse_digest_response(struct digest_auth_request *request,
        copy = t_strdup_noconst(t_strndup(data, size));
        while (*copy != '\0') {
                if (auth_digest_parse_keyvalue(&copy, &key, &value)) {
-                       if (!auth_handle_response(request, key, value, error)) {
+                       if (!auth_handle_response(request, key, value,
+                                                 error_r)) {
                                failed = TRUE;
                                break;
                        }
@@ -410,13 +411,13 @@ parse_digest_response(struct digest_auth_request *request,
 
        if (!failed) {
                if (!request->nonce_found) {
-                       *error = "Missing nonce parameter";
+                       *error_r = "Missing nonce parameter";
                        failed = TRUE;
                } else if (request->cnonce == NULL) {
-                       *error = "Missing cnonce parameter";
+                       *error_r = "Missing cnonce parameter";
                        failed = TRUE;
                } else if (request->username == NULL) {
-                       *error = "Missing username parameter";
+                       *error_r = "Missing username parameter";
                        failed = TRUE;
                }
        }