crypto: cavium - Fix the if condition to exit loop after timeout

[ Upstream commit 53d91ca76b6c426c546542a44c78507b42008c9e ]

The while loop breaks in the first run because of incorrect
if condition. It also causes the statements after the if to
appear dead.
Fix this by changing the condition from if(timeout--) to
if(!timeout--).

This bug was reported by Coverity Scan.
Report:
CID 1600859: (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement: udelay(30UL);

Fixes: 9e2c7d99941d ("crypto: cavium - Add Support for Octeon-tx CPT Engine")
Signed-off-by: Everest K.C. <everestkc@everestkc.com.np>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/crypto/cavium/cpt/cptpf_main.c b/drivers/crypto/cavium/cpt/cptpf_main.c
index d9362199423f2d0b77ef181d0a983c1532373c66..b3db27b142afba37543aafabe2143b9cf16e68e6 100644 (file)
--- a/drivers/crypto/cavium/cpt/cptpf_main.c
+++ b/drivers/crypto/cavium/cpt/cptpf_main.c
@@ -45,7 +45,7 @@ static void cpt_disable_cores(struct cpt_device *cpt, u64 coremask,
                dev_err(dev, "Cores still busy %llx", coremask);
                grp = cpt_read_csr64(cpt->reg_base,
                                     CPTX_PF_EXEC_BUSY(0));
-               if (timeout--)
+               if (!timeout--)
                        break;
 
                udelay(CSR_DELAY);
@@ -395,7 +395,7 @@ static void cpt_disable_all_cores(struct cpt_device *cpt)
                dev_err(dev, "Cores still busy");
                grp = cpt_read_csr64(cpt->reg_base,
                                     CPTX_PF_EXEC_BUSY(0));
-               if (timeout--)
+               if (!timeout--)
                        break;
 
                udelay(CSR_DELAY);