]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
drop gup-avoid-stack-expansion-warning-for-known-good-case.patch from all queues
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 4 Jul 2023 13:33:17 +0000 (14:33 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 4 Jul 2023 13:33:17 +0000 (14:33 +0100)
queue-6.1/gup-avoid-stack-expansion-warning-for-known-good-case.patch [deleted file]
queue-6.1/series
queue-6.3/gup-avoid-stack-expansion-warning-for-known-good-case.patch [deleted file]
queue-6.3/series
queue-6.4/gup-avoid-stack-expansion-warning-for-known-good-case.patch [deleted file]
queue-6.4/series

diff --git a/queue-6.1/gup-avoid-stack-expansion-warning-for-known-good-case.patch b/queue-6.1/gup-avoid-stack-expansion-warning-for-known-good-case.patch
deleted file mode 100644 (file)
index 7f83903..0000000
+++ /dev/null
@@ -1,45 +0,0 @@
-From eee9c708cc89b4600c6e6cdda5bc2b8b4dad96cb Mon Sep 17 00:00:00 2001
-From: Linus Torvalds <torvalds@linux-foundation.org>
-Date: Thu, 29 Jun 2023 12:36:47 -0700
-Subject: gup: avoid stack expansion warning for known-good case
-
-From: Linus Torvalds <torvalds@linux-foundation.org>
-
-commit eee9c708cc89b4600c6e6cdda5bc2b8b4dad96cb upstream.
-
-In commit a425ac5365f6 ("gup: add warning if some caller would seem to
-want stack expansion") I added a temporary warning to catch any strange
-GUP users that would be impacted by the fact that GUP no longer extends
-the stack.
-
-But it turns out that the warning is most easily triggered through
-__access_remote_vm(), that already knows to expand the stack - it just
-does it *after* calling GUP.  So the warning is easy to trigger by just
-running gdb (or similar) and accessing things remotely under the stack.
-
-This just adds a temporary extra "expand stack early" to avoid the
-warning for the already converted case - not because the warning is bad,
-but because getting the warning for this known good case would then hide
-any subsequent warnings for any actually interesting cases.
-
-Let's try to remember to revert this change when we remove the warnings.
-
-Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
----
- mm/memory.c |    4 ++++
- 1 file changed, 4 insertions(+)
-
---- a/mm/memory.c
-+++ b/mm/memory.c
-@@ -5656,6 +5656,10 @@ int __access_remote_vm(struct mm_struct
-                       return 0;
-       }
-+      /* Avoid triggering the temporary warning in __get_user_pages */
-+      if (!vma_lookup(mm, addr) && !expand_stack(mm, addr))
-+              return 0;
-+
-       /* ignore errors, just check how much was successfully transferred */
-       while (len) {
-               int bytes, ret, offset;
index 59f350d086924925a36abcaf77e17123952a0e38..1d7a256897a7a15ebff30aa36793987ec2f6b31a 100644 (file)
@@ -10,4 +10,3 @@ scripts-tags.sh-resolve-gtags-empty-index-generation.patch
 docs-set-minimal-gtags-gnu-global-version-to-6.6.5.patch
 drm-amdgpu-validate-vm-ioctl-flags.patch
 drm-amd-display-ensure-vmin-and-vmax-adjust-for-dce.patch
-gup-avoid-stack-expansion-warning-for-known-good-case.patch
diff --git a/queue-6.3/gup-avoid-stack-expansion-warning-for-known-good-case.patch b/queue-6.3/gup-avoid-stack-expansion-warning-for-known-good-case.patch
deleted file mode 100644 (file)
index fbfb121..0000000
+++ /dev/null
@@ -1,45 +0,0 @@
-From eee9c708cc89b4600c6e6cdda5bc2b8b4dad96cb Mon Sep 17 00:00:00 2001
-From: Linus Torvalds <torvalds@linux-foundation.org>
-Date: Thu, 29 Jun 2023 12:36:47 -0700
-Subject: gup: avoid stack expansion warning for known-good case
-
-From: Linus Torvalds <torvalds@linux-foundation.org>
-
-commit eee9c708cc89b4600c6e6cdda5bc2b8b4dad96cb upstream.
-
-In commit a425ac5365f6 ("gup: add warning if some caller would seem to
-want stack expansion") I added a temporary warning to catch any strange
-GUP users that would be impacted by the fact that GUP no longer extends
-the stack.
-
-But it turns out that the warning is most easily triggered through
-__access_remote_vm(), that already knows to expand the stack - it just
-does it *after* calling GUP.  So the warning is easy to trigger by just
-running gdb (or similar) and accessing things remotely under the stack.
-
-This just adds a temporary extra "expand stack early" to avoid the
-warning for the already converted case - not because the warning is bad,
-but because getting the warning for this known good case would then hide
-any subsequent warnings for any actually interesting cases.
-
-Let's try to remember to revert this change when we remove the warnings.
-
-Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
----
- mm/memory.c |    4 ++++
- 1 file changed, 4 insertions(+)
-
---- a/mm/memory.c
-+++ b/mm/memory.c
-@@ -5628,6 +5628,10 @@ int __access_remote_vm(struct mm_struct
-                       return 0;
-       }
-+      /* Avoid triggering the temporary warning in __get_user_pages */
-+      if (!vma_lookup(mm, addr) && !expand_stack(mm, addr))
-+              return 0;
-+
-       /* ignore errors, just check how much was successfully transferred */
-       while (len) {
-               int bytes, ret, offset;
index 4b5e67103623439ccf11f8bf8097ad199db1f18b..e886dcd237e4efee35d200c5b437df0b35710d7c 100644 (file)
@@ -11,4 +11,3 @@ docs-set-minimal-gtags-gnu-global-version-to-6.6.5.patch
 dm-ioctl-avoid-double-fetch-of-version.patch
 drm-amdgpu-validate-vm-ioctl-flags.patch
 drm-amd-display-ensure-vmin-and-vmax-adjust-for-dce.patch
-gup-avoid-stack-expansion-warning-for-known-good-case.patch
diff --git a/queue-6.4/gup-avoid-stack-expansion-warning-for-known-good-case.patch b/queue-6.4/gup-avoid-stack-expansion-warning-for-known-good-case.patch
deleted file mode 100644 (file)
index 4dcb38a..0000000
+++ /dev/null
@@ -1,45 +0,0 @@
-From eee9c708cc89b4600c6e6cdda5bc2b8b4dad96cb Mon Sep 17 00:00:00 2001
-From: Linus Torvalds <torvalds@linux-foundation.org>
-Date: Thu, 29 Jun 2023 12:36:47 -0700
-Subject: gup: avoid stack expansion warning for known-good case
-
-From: Linus Torvalds <torvalds@linux-foundation.org>
-
-commit eee9c708cc89b4600c6e6cdda5bc2b8b4dad96cb upstream.
-
-In commit a425ac5365f6 ("gup: add warning if some caller would seem to
-want stack expansion") I added a temporary warning to catch any strange
-GUP users that would be impacted by the fact that GUP no longer extends
-the stack.
-
-But it turns out that the warning is most easily triggered through
-__access_remote_vm(), that already knows to expand the stack - it just
-does it *after* calling GUP.  So the warning is easy to trigger by just
-running gdb (or similar) and accessing things remotely under the stack.
-
-This just adds a temporary extra "expand stack early" to avoid the
-warning for the already converted case - not because the warning is bad,
-but because getting the warning for this known good case would then hide
-any subsequent warnings for any actually interesting cases.
-
-Let's try to remember to revert this change when we remove the warnings.
-
-Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
----
- mm/memory.c |    4 ++++
- 1 file changed, 4 insertions(+)
-
---- a/mm/memory.c
-+++ b/mm/memory.c
-@@ -5721,6 +5721,10 @@ int __access_remote_vm(struct mm_struct
-                       return 0;
-       }
-+      /* Avoid triggering the temporary warning in __get_user_pages */
-+      if (!vma_lookup(mm, addr) && !expand_stack(mm, addr))
-+              return 0;
-+
-       /* ignore errors, just check how much was successfully transferred */
-       while (len) {
-               int bytes, ret, offset;
index 042c966140b9222fbb7f76b9b2ca09d128e621c0..36a2e61daaaa07da26ab5ec7858c5e43bf6ab661 100644 (file)
@@ -12,4 +12,3 @@ docs-set-minimal-gtags-gnu-global-version-to-6.6.5.patch
 dm-ioctl-avoid-double-fetch-of-version.patch
 drm-amdgpu-validate-vm-ioctl-flags.patch
 arch-arm64-mm-fault-fix-undeclared-variable-error-in-do_page_fault.patch
-gup-avoid-stack-expansion-warning-for-known-good-case.patch