]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mfd: kempld-core: Fix callback return value check
authorAmeya Palande <2ameya@gmail.com>
Thu, 26 Feb 2015 20:05:51 +0000 (12:05 -0800)
committerLuis Henriques <luis.henriques@canonical.com>
Fri, 10 Apr 2015 09:03:55 +0000 (10:03 +0100)
commit c8648508ebfc597058d2cd00b6c539110264a167 upstream.

On success, callback function returns 0. So invert the if condition
check so that we can break out of loop.

Signed-off-by: Ameya Palande <2ameya@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
drivers/mfd/kempld-core.c

index f7ff0188603deac34e0c872d642efd4a775e1549..7112308fa8bec27b1c3d0a18555e6d9c7364e67e 100644 (file)
@@ -738,7 +738,7 @@ static int __init kempld_init(void)
        if (force_device_id[0]) {
                for (id = kempld_dmi_table; id->matches[0].slot != DMI_NONE; id++)
                        if (strstr(id->ident, force_device_id))
-                               if (id->callback && id->callback(id))
+                               if (id->callback && !id->callback(id))
                                        break;
                if (id->matches[0].slot == DMI_NONE)
                        return -ENODEV;