]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
closes bpo-34474: Python/bltinmodule.c: Add missing NULL check in builtin_sum_impl...
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Fri, 24 Aug 2018 04:59:16 +0000 (00:59 -0400)
committerGitHub <noreply@github.com>
Fri, 24 Aug 2018 04:59:16 +0000 (00:59 -0400)
Reported by Svace static analyzer.
(cherry picked from commit 2b824b2538c4a5f9f520c5de8a1eae5a0c181a94)

Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
Python/bltinmodule.c

index 94f290853ccf9f937742420e2404eef1070a3d0a..6306c3ac56415c417b53083c71a1fbd85b4a2af4 100644 (file)
@@ -2431,6 +2431,11 @@ builtin_sum_impl(PyObject *module, PyObject *iterable, PyObject *start)
                 }
             }
             result = PyFloat_FromDouble(f_result);
+            if (result == NULL) {
+                Py_DECREF(item);
+                Py_DECREF(iter);
+                return NULL;
+            }
             temp = PyNumber_Add(result, item);
             Py_DECREF(result);
             Py_DECREF(item);