]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/xe/sync: Fix user fence leak on alloc failure
authorShuicheng Lin <shuicheng.lin@intel.com>
Thu, 19 Feb 2026 23:35:19 +0000 (23:35 +0000)
committerMatthew Brost <matthew.brost@intel.com>
Fri, 20 Feb 2026 18:49:08 +0000 (10:49 -0800)
When dma_fence_chain_alloc() fails, properly release the user fence
reference to prevent a memory leak.

Fixes: adda4e855ab6 ("drm/xe: Enforce correct user fence signaling order using")
Cc: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Link: https://patch.msgid.link/20260219233516.2938172-6-shuicheng.lin@intel.com
drivers/gpu/drm/xe/xe_sync.c

index f03ab2e27284d3e6722c695375f6efb46fa9dd8d..52cefbd985ac0984d089357242d9ea689fa714e0 100644 (file)
@@ -206,8 +206,10 @@ int xe_sync_entry_parse(struct xe_device *xe, struct xe_file *xef,
                        if (XE_IOCTL_DBG(xe, IS_ERR(sync->ufence)))
                                return PTR_ERR(sync->ufence);
                        sync->ufence_chain_fence = dma_fence_chain_alloc();
-                       if (!sync->ufence_chain_fence)
-                               return -ENOMEM;
+                       if (!sync->ufence_chain_fence) {
+                               err = -ENOMEM;
+                               goto free_sync;
+                       }
                        sync->ufence_syncobj = ufence_syncobj;
                }