]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-43981: Fix error in idle-test leak test (GH-25739)
authorTerry Jan Reedy <tjreedy@udel.edu>
Fri, 30 Apr 2021 03:52:47 +0000 (23:52 -0400)
committerGitHub <noreply@github.com>
Fri, 30 Apr 2021 03:52:47 +0000 (23:52 -0400)
Remove call to macosx.setupApp, which calls macosc.overrideRootMenu, which modifies
the menus, which results in two failures in the second round of the leak test.

Lib/idlelib/idle_test/test_sidebar.py

index 7228d0ee731fa582bd299d1c7c3c611bde6819be..0497f6d05139e88829570bd54cbfc6243eb1e117 100644 (file)
@@ -7,11 +7,10 @@ import unittest
 import unittest.mock
 from test.support import requires, swap_attr
 import tkinter as tk
-from .tkinter_testing_utils import run_in_tk_mainloop
+from idlelib.idle_test.tkinter_testing_utils import run_in_tk_mainloop
 
 from idlelib.delegator import Delegator
 from idlelib.editor import fixwordbreaks
-from idlelib import macosx
 from idlelib.percolator import Percolator
 import idlelib.pyshell
 from idlelib.pyshell import fix_x11_paste, PyShell, PyShellFileList
@@ -408,7 +407,7 @@ class ShellSidebarTest(unittest.TestCase):
         fix_x11_paste(root)
 
         cls.flist = flist = PyShellFileList(root)
-        macosx.setupApp(root, flist)
+        # See #43981 about macosx.setupApp(root, flist) causing failure.
         root.update_idletasks()
 
         cls.init_shell()