]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/msm/mdp4: remove the use of dev_err_probe()
authorLiao Yuanhong <liaoyuanhong@vivo.com>
Wed, 20 Aug 2025 13:12:56 +0000 (21:12 +0800)
committerDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Tue, 9 Sep 2025 14:27:42 +0000 (17:27 +0300)
Logging messages that show some type of "out of memory" error are generally
unnecessary as there is a generic message and a stack dump done by the
memory subsystem. These messages generally increase kernel size without
much added value[1].

The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore,
remove the useless call to dev_err_probe(), and just return the value
instead.

[1]: https://lore.kernel.org/lkml/1402419340.30479.18.camel@joe-AO725/

Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/670017/
Link: https://lore.kernel.org/r/20250820131300.499727-1-liaoyuanhong@vivo.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c

index 1d2a1e4f6ce7d02516b9497a494bb1e46297f55a..809ca191e9de786f3019431bdef567d2ba62d148 100644 (file)
@@ -512,7 +512,7 @@ static int mdp4_probe(struct platform_device *pdev)
 
        mdp4_kms = devm_kzalloc(dev, sizeof(*mdp4_kms), GFP_KERNEL);
        if (!mdp4_kms)
-               return dev_err_probe(dev, -ENOMEM, "failed to allocate kms\n");
+               return -ENOMEM;
 
        mdp4_kms->mmio = msm_ioremap(pdev, NULL);
        if (IS_ERR(mdp4_kms->mmio))