]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
network: veth: use SYNTHETIC_ERRNO() macro or use real error cause
authorYu Watanabe <watanabe.yu+github@gmail.com>
Thu, 25 Nov 2021 11:59:48 +0000 (20:59 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 26 Nov 2021 21:37:58 +0000 (06:37 +0900)
src/network/netdev/veth.c

index cdbbf3936145dafda53f6b835e159508e4bb9827..8236a433158c175883854ba44eb03d9812c1c17e 100644 (file)
@@ -58,20 +58,17 @@ static int netdev_veth_verify(NetDev *netdev, const char *filename) {
 
         assert(v);
 
-        if (!v->ifname_peer) {
-                log_netdev_warning(netdev, "Veth NetDev without peer name configured in %s. Ignoring",
-                                   filename);
-                return -EINVAL;
-        }
+        if (!v->ifname_peer)
+                return log_netdev_warning_errno(netdev, SYNTHETIC_ERRNO(EINVAL),
+                                                "Veth NetDev without peer name configured in %s. Ignoring",
+                                                filename);
 
         if (!v->mac_peer) {
                 r = netdev_get_mac(v->ifname_peer, &v->mac_peer);
-                if (r < 0) {
-                        log_netdev_warning(netdev,
-                                           "Failed to generate predictable MAC address for %s. Ignoring",
-                                           v->ifname_peer);
-                        return -EINVAL;
-                }
+                if (r < 0)
+                        return log_netdev_warning_errno(netdev, r,
+                                                        "Failed to generate predictable MAC address for %s: %m",
+                                                        v->ifname_peer);
         }
 
         return 0;