On elf_update, remember when we mmap()

Otherwise we skip the munmap() later. This leaks resources.

Signed-off-by: Ulf Hermann <ulf.hermann@qt.io>

diff --git a/libelf/ChangeLog b/libelf/ChangeLog
index d425e50a7201c1e0fbc7ab719784a32ca94687e1..4f232289affe8263d35bdec0c67476baf23942b0 100644 (file)
--- a/libelf/ChangeLog
+++ b/libelf/ChangeLog
@@ -1,3 +1,7 @@
+2017-04-20  Ulf Hermann  <ulf.hermann@qt.io>
+
+       * elf_update.c: Set ELF_F_MMAPPED flag if we mmap from elf_update.
+
 2017-04-19  Mark Wielaard  <mark@klomp.org>
 
        * elf_getarsym.c (elf_getarsym): Initialize n to zero.

diff --git a/libelf/elf_update.c b/libelf/elf_update.c
index c635eb328c27c0023e6b6e200ed14cd24074c0bf..8ce078291169b51ce288091bcc47e14895cea7c3 100644 (file)
--- a/libelf/elf_update.c
+++ b/libelf/elf_update.c
@@ -74,6 +74,8 @@ write_file (Elf *elf, off_t size, int change_bo, size_t shnum)
                               MAP_SHARED, elf->fildes, 0);
       if (unlikely (elf->map_address == MAP_FAILED))
        elf->map_address = NULL;
+      else
+       elf->flags |= ELF_F_MMAPPED;
     }
 
   if (elf->map_address != NULL)