]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
leds: bcm63138/cros_ec: Move MODULE_DEVICE_TABLE next to the table itself
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Tue, 5 May 2026 10:28:45 +0000 (12:28 +0200)
committerLee Jones <lee@kernel.org>
Wed, 17 Jun 2026 10:28:43 +0000 (11:28 +0100)
By convention MODULE_DEVICE_TABLE() immediately follows the ID table it
exports, because this is easier to read and verify.  It also makes more
sense since #ifdef for ACPI or OF could hide both of them.

Most of the privers already have this correctly placed, so adjust
the missing ones.  No functional impact.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Acked-by: Thomas Weißschuh <linux@weissschuh.net> # leds-cros_ec.c
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20260505102846.186219-2-krzysztof.kozlowski@oss.qualcomm.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/blink/leds-bcm63138.c
drivers/leds/leds-cros_ec.c

index ef2e511438ccbf8ca6dee91939bcd6fd94e55830..45c0662df9338d446bd53cf787a49cab7c106fbc 100644 (file)
@@ -296,6 +296,7 @@ static const struct of_device_id bcm63138_leds_of_match_table[] = {
        { .compatible = "brcm,bcm63138-leds", },
        { },
 };
+MODULE_DEVICE_TABLE(of, bcm63138_leds_of_match_table);
 
 static struct platform_driver bcm63138_leds_driver = {
        .probe = bcm63138_leds_probe,
@@ -310,4 +311,3 @@ module_platform_driver(bcm63138_leds_driver);
 MODULE_AUTHOR("Rafał Miłecki");
 MODULE_DESCRIPTION("Broadcom BCM63138 SoC LED driver");
 MODULE_LICENSE("GPL");
-MODULE_DEVICE_TABLE(of, bcm63138_leds_of_match_table);
index bea3cc3fbfd2d4881e986a150facbf2b3b426a0a..6592ceee866a2d583d68e1fb25f7924016d2884a 100644 (file)
@@ -249,6 +249,7 @@ static const struct platform_device_id cros_ec_led_id[] = {
        { "cros-ec-led", 0 },
        {}
 };
+MODULE_DEVICE_TABLE(platform, cros_ec_led_id);
 
 static struct platform_driver cros_ec_led_driver = {
        .driver.name    = "cros-ec-led",
@@ -257,7 +258,6 @@ static struct platform_driver cros_ec_led_driver = {
 };
 module_platform_driver(cros_ec_led_driver);
 
-MODULE_DEVICE_TABLE(platform, cros_ec_led_id);
 MODULE_DESCRIPTION("ChromeOS EC LED Driver");
 MODULE_AUTHOR("Thomas Weißschuh <linux@weissschuh.net");
 MODULE_LICENSE("GPL");