]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ALSA: usb-audio: Fix wrong kfree issue in snd_usb_endpoint_free_all
authorWan Jiabing <wanjiabing@vivo.com>
Wed, 18 May 2022 02:16:16 +0000 (10:16 +0800)
committerSasha Levin <sashal@kernel.org>
Fri, 15 Mar 2024 14:48:23 +0000 (10:48 -0400)
[ Upstream commit 03a8b0df757f1beb21ba1626e23ca7412e48b525 ]

Fix following coccicheck error:
./sound/usb/endpoint.c:1671:8-10: ERROR: reference preceded by free on line 1671.

Here should be 'cp' rather than 'ip'.

Fixes: c11117b634f4 ("ALSA: usb-audio: Refcount multiple accesses on the single clock")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Link: https://lore.kernel.org/r/20220518021617.10114-1-wanjiabing@vivo.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/usb/endpoint.c

index 26af199f3836ee5edb8f77f4de617e26ca993cd3..8188113ca83f2101532f914d87355c8437ac4308 100644 (file)
@@ -1720,7 +1720,7 @@ void snd_usb_endpoint_free_all(struct snd_usb_audio *chip)
                kfree(ip);
 
        list_for_each_entry_safe(cp, cn, &chip->clock_ref_list, list)
-               kfree(ip);
+               kfree(cp);
 }
 
 /*