memory: renesas-rpc-if: fix possible NULL pointer dereference of resource

[ Upstream commit 59e27d7c94aa02da039b000d33c304c179395801 ]

The platform_get_resource_byname() can return NULL which would be
immediately dereferenced by resource_size().  Instead dereference it
after validating the resource.

Addresses-Coverity: Dereference null return value
Fixes: ca7d8b980b67 ("memory: add Renesas RPC-IF driver")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Link: https://lore.kernel.org/r/20210407154357.70200-1-krzysztof.kozlowski@canonical.com
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c
index 8d36e221def149074b9ab3d0f6c4c74ee7248e24..45eed659b0c6de5f14266e2e9242b76f4e38bff4 100644 (file)
--- a/drivers/memory/renesas-rpc-if.c
+++ b/drivers/memory/renesas-rpc-if.c
@@ -192,10 +192,10 @@ int rpcif_sw_init(struct rpcif *rpc, struct device *dev)
        }
 
        res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dirmap");
-       rpc->size = resource_size(res);
        rpc->dirmap = devm_ioremap_resource(&pdev->dev, res);
        if (IS_ERR(rpc->dirmap))
                rpc->dirmap = NULL;
+       rpc->size = resource_size(res);
 
        rpc->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);