]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: spi-fsl-lpspi: use min_t() to improve code
authorQianfeng Rong <rongqianfeng@vivo.com>
Fri, 15 Aug 2025 08:21:15 +0000 (16:21 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 18 Aug 2025 12:14:02 +0000 (13:14 +0100)
Use min_t() to reduce the code in fsl_lpspi_setup_transfer() and
improve its readability.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Link: https://patch.msgid.link/20250815082118.586422-2-rongqianfeng@vivo.com
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-lpspi.c

index 67d4000c3cef5b6da519355797c06d7323fedaea..f5595e2ba2d560da7d7aacea1864f467cfb581ac 100644 (file)
@@ -25,6 +25,7 @@
 #include <linux/spi/spi.h>
 #include <linux/spi/spi_bitbang.h>
 #include <linux/types.h>
+#include <linux/minmax.h>
 
 #define DRIVER_NAME "fsl_lpspi"
 
@@ -475,10 +476,9 @@ static int fsl_lpspi_setup_transfer(struct spi_controller *controller,
                fsl_lpspi->tx = fsl_lpspi_buf_tx_u32;
        }
 
-       if (t->len <= fsl_lpspi->txfifosize)
-               fsl_lpspi->watermark = t->len;
-       else
-               fsl_lpspi->watermark = fsl_lpspi->txfifosize;
+       fsl_lpspi->watermark = min_t(typeof(fsl_lpspi->watermark),
+                                    fsl_lpspi->txfifosize,
+                                    t->len);
 
        if (fsl_lpspi_can_dma(controller, spi, t))
                fsl_lpspi->usedma = true;