]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
btrfs: send: only use boolean variables at process_recorded_refs()
authorFilipe Manana <fdmanana@suse.com>
Tue, 19 Aug 2025 02:15:56 +0000 (22:15 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:31:04 +0000 (16:31 +0200)
[ Upstream commit 9453fe329789073d9a971de01da5902c32c1a01a ]

We have several local variables at process_recorded_refs() that are used
as booleans, with some of them having a 'bool' type while two of them
having an 'int' type. Change this to make them all use the 'bool' type
which is more clear and to make everything more consistent.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Stable-dep-of: 005b0a0c24e1 ("btrfs: send: use fallocate for hole punching with send stream v2")
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/btrfs/send.c

index 464c37c2b33dadcc70c31ad94cdaded4779f8440..deecd92cc512389994f4386d02328ddd3eeb2383 100644 (file)
@@ -4179,9 +4179,9 @@ static int process_recorded_refs(struct send_ctx *sctx, int *pending_move)
        u64 ow_inode = 0;
        u64 ow_gen;
        u64 ow_mode;
-       int did_overwrite = 0;
-       int is_orphan = 0;
        u64 last_dir_ino_rm = 0;
+       bool did_overwrite = false;
+       bool is_orphan = false;
        bool can_rename = true;
        bool orphanized_dir = false;
        bool orphanized_ancestor = false;
@@ -4223,14 +4223,14 @@ static int process_recorded_refs(struct send_ctx *sctx, int *pending_move)
                if (ret < 0)
                        goto out;
                if (ret)
-                       did_overwrite = 1;
+                       did_overwrite = true;
        }
        if (sctx->cur_inode_new || did_overwrite) {
                ret = gen_unique_name(sctx, sctx->cur_ino,
                                sctx->cur_inode_gen, valid_path);
                if (ret < 0)
                        goto out;
-               is_orphan = 1;
+               is_orphan = true;
        } else {
                ret = get_cur_path(sctx, sctx->cur_ino, sctx->cur_inode_gen,
                                valid_path);
@@ -4453,7 +4453,7 @@ static int process_recorded_refs(struct send_ctx *sctx, int *pending_move)
                        ret = send_rename(sctx, valid_path, cur->full_path);
                        if (ret < 0)
                                goto out;
-                       is_orphan = 0;
+                       is_orphan = false;
                        ret = fs_path_copy(valid_path, cur->full_path);
                        if (ret < 0)
                                goto out;
@@ -4514,7 +4514,7 @@ static int process_recorded_refs(struct send_ctx *sctx, int *pending_move)
                                        sctx->cur_inode_gen, valid_path);
                        if (ret < 0)
                                goto out;
-                       is_orphan = 1;
+                       is_orphan = true;
                }
 
                list_for_each_entry(cur, &sctx->deleted_refs, list) {