vfs_ceph{_new}: do not set errno upon successful call to libcephfs

There is code in Samba that expects errno from a previous system call
to be preserved through a subsequent system call. Thus, avoid setting
"errno = 0" in status_code() and lstatus_code() upon successful return
from libcephfs API call.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15686

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>

diff --git a/source3/modules/vfs_ceph.c b/source3/modules/vfs_ceph.c
index 1dd136e569b1f50ab8071a382e187446c0a00efe..fd450af16c26c3cb56d7e5efa4efc7625ef0fa67 100644 (file)
--- a/source3/modules/vfs_ceph.c
+++ b/source3/modules/vfs_ceph.c
@@ -66,7 +66,6 @@ static inline int status_code(int ret)
                errno = -ret;
                return -1;
        }
-       errno = 0;
        return ret;
 }
 
@@ -76,7 +75,6 @@ static inline ssize_t lstatus_code(intmax_t ret)
                errno = -((int)ret);
                return -1;
        }
-       errno = 0;
        return (ssize_t)ret;
 }
 

diff --git a/source3/modules/vfs_ceph_new.c b/source3/modules/vfs_ceph_new.c
index 99d4a1fe40749523ae64d10ddab58d9636963682..c11f5f2461654198acb5e850f90d1545dd499909 100644 (file)
--- a/source3/modules/vfs_ceph_new.c
+++ b/source3/modules/vfs_ceph_new.c
@@ -66,7 +66,6 @@ static int status_code(int ret)
                errno = -ret;
                return -1;
        }
-       errno = 0;
        return ret;
 }
 
@@ -76,7 +75,6 @@ static ssize_t lstatus_code(intmax_t ret)
                errno = -((int)ret);
                return -1;
        }
-       errno = 0;
        return (ssize_t)ret;
 }