Fix issue #3547: ctypes is confused by bitfields of varying integer types

Reviewed by Fredrik Lundh and Skip Montanaro.

diff --git a/Lib/ctypes/test/test_bitfields.py b/Lib/ctypes/test/test_bitfields.py
index 2867cbf93e6c05855e9b6e2c1673c42295e96d18..ddd753ea09b0c835a55654ea825cdbfca790948a 100644 (file)
--- a/Lib/ctypes/test/test_bitfields.py
+++ b/Lib/ctypes/test/test_bitfields.py
@@ -215,6 +215,21 @@ class BitFieldTest(unittest.TestCase):
                         ("b", c_ubyte, 4)]
         self.failUnlessEqual(sizeof(X), sizeof(c_byte))
 
+    def test_mixed_4(self):
+        class X(Structure):
+            _fields_ = [("a", c_short, 4),
+                        ("b", c_short, 4),
+                        ("c", c_int, 24),
+                        ("d", c_short, 4),
+                        ("e", c_short, 4),
+                        ("f", c_int, 24)]
+        # MS compilers do NOT combine c_short and c_int into
+        # one field, gcc does.
+        if os.name in ("nt", "ce"):
+            self.failUnlessEqual(sizeof(X), sizeof(c_int) * 4)
+        else:
+            self.failUnlessEqual(sizeof(X), sizeof(c_int) * 2)
+
     def test_anon_bitfields(self):
         # anonymous bit-fields gave a strange error message
         class X(Structure):

diff --git a/Misc/NEWS b/Misc/NEWS
index 0c222331c598a835d8f0e41fecd25ad38d59f681..37bb63439630663987b566306200e057863162f9 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -15,6 +15,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #3547: Fixed ctypes structures bitfields of varying integer
+  sizes.
+
 - Issue #3879: A regression in urllib.getproxies_enviroment was fixed.
 
 Build

diff --git a/Modules/_ctypes/cfield.c b/Modules/_ctypes/cfield.c
index ba837ecca37958156950ce85c53d499273a7dd34..b9024bb7491a9584d95248646e612fe26c1ffdfa 100644 (file)
--- a/Modules/_ctypes/cfield.c
+++ b/Modules/_ctypes/cfield.c
@@ -163,7 +163,7 @@ CField_FromDesc(PyObject *desc, Py_ssize_t index,
                break;
 
        case EXPAND_BITFIELD:
-               /* XXX needs more */
+               *poffset += dict->size - *pfield_size/8;
                *psize += dict->size - *pfield_size/8;
 
                *pfield_size = dict->size * 8;