]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
bus-proxy: don't filter directed signals 804/head
authorDavid Herrmann <dh.herrmann@gmail.com>
Fri, 31 Jul 2015 09:16:13 +0000 (11:16 +0200)
committerDavid Herrmann <dh.herrmann@gmail.com>
Fri, 31 Jul 2015 11:28:23 +0000 (13:28 +0200)
NameAcquired and NameLost are directed signals. Never ever filter them on
dbus1. On dbus1, filters *exclusively* apply to broadcasts! Hence, we
must always forward directed signals unconditionally!

src/bus-proxyd/synthesize.c

index c26de9af6a3bc5f9de3d813d679f9699da624991..15d99103f6dc0aeaff2731ed339ccd524792eb3a 100644 (file)
@@ -222,18 +222,5 @@ int synthesize_name_acquired(Proxy *p, sd_bus *a, sd_bus *b, sd_bus_message *m)
         if (r < 0)
                 return r;
 
-        /*
-         * Make sure to only forward NameLost/NameAcquired messages if they
-         * match an installed MATCH rule of the local client. We really must
-         * not send messages the client doesn't expect.
-         */
-
-        r = bus_match_run(b, &b->match_callbacks, n);
-        if (r >= 0 && p->message_matched)
-                r = sd_bus_send(b, n, NULL);
-
-        p->message_matched = false;
-        p->synthetic_matched = false;
-
-        return r;
+        return sd_bus_send(b, n, NULL);
 }