network/ndisc: fix use-of-uninitialized-value on failure path

Fixes a bug in f44eebd1bab9327c5dd3a281196bd07192134d3b.

Also slightly adjust log message.

diff --git a/src/network/networkd-ndisc.c b/src/network/networkd-ndisc.c
index c3be14c20f2953805b2b5c4456631cfcfb8301e7..dfcd400a52496ddb22dc1172a8e949a3a5cc93d8 100644 (file)
--- a/src/network/networkd-ndisc.c
+++ b/src/network/networkd-ndisc.c
@@ -526,7 +526,7 @@ static int ndisc_router_process_onlink_prefix(Link *link, sd_ndisc_router *rt) {
         /* Prefix Information option does not have preference, hence we use the 'main' preference here */
         r = sd_ndisc_router_get_preference(rt, &preference);
         if (r < 0)
-                log_link_warning_errno(link, r, "Failed to get default router preference from RA: %m");
+                return log_link_warning_errno(link, r, "Failed to get router preference from RA: %m");
 
         r = route_new(&route);
         if (r < 0)