s3:script: Fix shellcheck errors in test_smbspool.sh

test_smbspool.sh:124:24: error: Couldn't parse this test expression. Fix
to allow more checks. [SC1073]

test_smbspool.sh:124:44: error: If grouping expressions inside [..], use
\( ..\). [SC1026]

test_smbspool.sh:124:46: error: Expected test to end here (don't wrap
commands in []/[[]]). Fix any mentioned problems and try again. [SC1072]

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>

diff --git a/source3/script/tests/test_smbspool.sh b/source3/script/tests/test_smbspool.sh
index 1c3c02e250273d16ce758bfce87cfec459f4d1b6..1fcc9a8cc0130e04e58ab8da486b1879d6380fde 100755 (executable)
--- a/source3/script/tests/test_smbspool.sh
+++ b/source3/script/tests/test_smbspool.sh
@@ -121,7 +121,7 @@ test_vlp_verify()
        fi
 
        jobid=$(echo "$out" | awk '/[0-9]+/ { print $1 };')
-       if [ -z "$jobid" ] || [ $jobid -lt 100 || [ $jobid -gt 2000 ]; then
+       if [ -z "$jobid" ] || [ $jobid -lt 100 ] || [ $jobid -gt 2000 ]; then
                echo "Invalid jobid: $jobid"
                echo "$out"
                return 1