]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
winbind: Fix the clang build
authorVolker Lendecke <vl@samba.org>
Wed, 31 Jul 2019 09:40:20 +0000 (11:40 +0200)
committerJeremy Allison <jra@samba.org>
Tue, 6 Aug 2019 21:49:28 +0000 (21:49 +0000)
clang complains that lm_resp and nt_resp is used uninitialized. This
is true for the "goto done;" in line 2644. This directly calls
log_authentication without having initialized those two blobs.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/winbindd/winbindd_pam.c

index eaf16d0dcedeb09ce8509910974188a249a7f9ff..9b220c46c70e5a105aa2a2a1a7bf3e78e19a7e57 100644 (file)
@@ -2611,7 +2611,7 @@ enum winbindd_result winbindd_dual_pam_auth_crap(struct winbindd_domain *domain,
        uint32_t flags = 0;
        uint16_t validation_level;
        union netr_Validation *validation = NULL;
-       DATA_BLOB lm_resp, nt_resp;
+       DATA_BLOB lm_resp = { 0 }, nt_resp = { 0 };
        const struct timeval start_time = timeval_current();
        const struct tsocket_address *remote = NULL;
        const struct tsocket_address *local = NULL;