]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: amlogic-spifc-a1: Handle devm_pm_runtime_enable() errors
authorHaotian Zhang <vulab@iscas.ac.cn>
Mon, 24 Nov 2025 01:58:52 +0000 (09:58 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 24 Nov 2025 11:31:27 +0000 (11:31 +0000)
devm_pm_runtime_enable() can fail due to memory allocation. The current
code ignores its return value, potentially causing runtime PM operations
to fail silently after autosuspend configuration.

Check the return value of devm_pm_runtime_enable() and return on failure.

Fixes: 909fac05b926 ("spi: add support for Amlogic A1 SPI Flash Controller")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20251124015852.937-1-vulab@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-amlogic-spifc-a1.c

index 18c9aa2cbc290d8ac179438ab42c27e1a722d422..eb503790017b23cc3faaab3a069b9947ac40876e 100644 (file)
@@ -353,7 +353,9 @@ static int amlogic_spifc_a1_probe(struct platform_device *pdev)
 
        pm_runtime_set_autosuspend_delay(spifc->dev, 500);
        pm_runtime_use_autosuspend(spifc->dev);
-       devm_pm_runtime_enable(spifc->dev);
+       ret = devm_pm_runtime_enable(spifc->dev);
+       if (ret)
+               return ret;
 
        ctrl->num_chipselect = 1;
        ctrl->dev.of_node = pdev->dev.of_node;