]> git.ipfire.org Git - thirdparty/dbus.git/commitdiff
dbus-spam: Ensure that payload_len is always initialized
authorSimon McVittie <smcv@collabora.com>
Wed, 25 Sep 2024 13:38:31 +0000 (14:38 +0100)
committerSimon McVittie <smcv@collabora.com>
Wed, 25 Sep 2024 13:42:15 +0000 (14:42 +0100)
A command like `dbus-test-tool spam --payload=abcde --bytes` could
previously have left the length uninitialized.

Detected by compiling with gcc 14.

Signed-off-by: Simon McVittie <smcv@collabora.com>
tools/dbus-spam.c

index 7c0a7168d9f235ce59e1067000ad576bb4a6cd6c..43f260ba30d50f8a51fa023cb8ca7e5efb513921 100644 (file)
@@ -164,7 +164,7 @@ dbus_test_tool_spam (int argc, char **argv)
   int queue_len = 1;
   const char *payload = NULL;
   char *payload_buf = NULL;
-  size_t payload_len;
+  size_t payload_len = 0;
   int payload_type = DBUS_TYPE_STRING;
   DBusMessage *template = NULL;
   dbus_bool_t flood = FALSE;
@@ -217,6 +217,7 @@ dbus_test_tool_spam (int argc, char **argv)
       else if (strstr (arg, "--payload=") == arg)
         {
           payload = arg + strlen ("--payload=");
+          payload_len = strlen (payload);
         }
       else if (strcmp (arg, "--stdin") == 0)
         {