]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
can: rcar_canfd: Fix controller mode setting
authorDuy Nguyen <duy.nguyen.rh@renesas.com>
Thu, 18 Sep 2025 07:03:45 +0000 (07:03 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 12 Oct 2025 11:01:03 +0000 (13:01 +0200)
[ Upstream commit 5cff263606a10102a0ea19ff579eaa18fd5577ad ]

Driver configures register to choose controller mode before
setting all channels to reset mode leading to failure.
The patch corrects operation of mode setting.

Signed-off-by: Duy Nguyen <duy.nguyen.rh@renesas.com>
Signed-off-by: Tranh Ha <tranh.ha.xb@renesas.com>
Link: https://patch.msgid.link/TYWPR01MB87434739F83E27EDCD23DF44B416A@TYWPR01MB8743.jpnprd01.prod.outlook.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/can/rcar/rcar_canfd.c

index 7f10213738e5cee75558e055f3b2c43a7453fb28..e2ae8d6a9de6482e7a49ce475279e406281ca1db 100644 (file)
@@ -870,9 +870,6 @@ static int rcar_canfd_reset_controller(struct rcar_canfd_global *gpriv)
        /* Reset Global error flags */
        rcar_canfd_write(gpriv->base, RCANFD_GERFL, 0x0);
 
-       /* Set the controller into appropriate mode */
-       rcar_canfd_set_mode(gpriv);
-
        /* Transition all Channels to reset mode */
        for_each_set_bit(ch, &gpriv->channels_mask, gpriv->info->max_channels) {
                rcar_canfd_clear_bit(gpriv->base,
@@ -892,6 +889,10 @@ static int rcar_canfd_reset_controller(struct rcar_canfd_global *gpriv)
                        return err;
                }
        }
+
+       /* Set the controller into appropriate mode */
+       rcar_canfd_set_mode(gpriv);
+
        return 0;
 }