rpc/dnsdata: do not crash if message attr missing (CID: 1414773)

This should be hard to trigger, but goto fail is always nicer than sig 11.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

diff --git a/source4/rpc_server/dnsserver/dnsdata.c b/source4/rpc_server/dnsserver/dnsdata.c
index 59e29f029a675dafa018d9eaec59a4dd4e84e16a..6a211ad9efdfefc2d0ec5e41e779c037bca1822b 100644 (file)
--- a/source4/rpc_server/dnsserver/dnsdata.c
+++ b/source4/rpc_server/dnsserver/dnsdata.c
@@ -794,6 +794,11 @@ struct dns_tree *dns_build_tree(TALLOC_CTX *mem_ctx, const char *name, struct ld
        /* Add all names in the result in a tree */
        for (i=0; i<res->count; i++) {
                ptr = ldb_msg_find_attr_as_string(res->msgs[i], "name", NULL);
+               if (ptr == NULL) {
+                       DBG_ERR("dnsserver: dns record has no name (%s)",
+                               ldb_dn_get_linearized(res->msgs[i]->dn));
+                       goto failed;
+               }
 
                if (strcmp(ptr, "@") == 0) {
                        base->data = res->msgs[i];