]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: rtw89: fix leak in rtw89_core_send_nullfunc()
authorFedor Pchelkin <pchelkin@ispras.ru>
Fri, 19 Sep 2025 21:08:49 +0000 (00:08 +0300)
committerPing-Ke Shih <pkshih@realtek.com>
Mon, 22 Sep 2025 05:58:52 +0000 (13:58 +0800)
If there is no rtwsta_link found in rtw89_core_send_nullfunc(), allocated
skb is leaked.  Free it on the error handling path.

Found by Linux Verification Center (linuxtesting.org).

Fixes: a8ba4acab7db ("wifi: rtw89: send nullfunc based on the given link")
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20250919210852.823912-4-pchelkin@ispras.ru
drivers/net/wireless/realtek/rtw89/core.c

index 1f44c7fc1c5e9fb79367408603d8ed225f9afec0..917b2adede61d789afaceca1f35c58546dce7c2f 100644 (file)
@@ -3961,6 +3961,7 @@ int rtw89_core_send_nullfunc(struct rtw89_dev *rtwdev, struct rtw89_vif_link *rt
        rtwsta_link = rtwsta->links[rtwvif_link->link_id];
        if (unlikely(!rtwsta_link)) {
                ret = -ENOLINK;
+               dev_kfree_skb_any(skb);
                goto out;
        }